From patchwork Thu Aug 11 19:02:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrej Krutak X-Patchwork-Id: 9275909 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D7CDC6022E for ; Thu, 11 Aug 2016 19:56:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C6A6228780 for ; Thu, 11 Aug 2016 19:56:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BBA7D28788; Thu, 11 Aug 2016 19:56:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FC1928780 for ; Thu, 11 Aug 2016 19:56:27 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id C5DBA267ED1; Thu, 11 Aug 2016 21:56:24 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 08C0D267B14; Thu, 11 Aug 2016 21:42:10 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0572F267AE7; Thu, 11 Aug 2016 21:42:06 +0200 (CEST) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by alsa0.perex.cz (Postfix) with ESMTP id 46B6526777A for ; Thu, 11 Aug 2016 21:04:14 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id o80so967358wme.0 for ; Thu, 11 Aug 2016 12:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ug43kfetvEUeCGo0p4Edd940mmuWIpGthgJ4IXm79E8=; b=GGGxap3BLV+Ahy4NU4RqlM3vKy0WCd5iC8Uan4D+m7qL1TqNtzycupwJanbeqEzN// IQ4WQb8SoGp6GBo6wgIpsmm+k/LDg6izI4ffrnXXKQJWspnS21Od9AfUEc4vN15jDbUq +l3+fA/2SfbFlgUdSXdveHukpiueVepP+YNhT7kjXaRTGmNfZ3TZrR3EncDm0FD+XanP +AF8ZhvBIQVwOSrAMJbujAfKOiAsAfMNv+viL/StZLM5xuhBBTfvq4KnyS735mBh/MBd 0MoZ+2vjpVlP79HRxNl7RO5qrZtG8dl0oJR7s+XbTJw/xmA9bwOdIEx7nVCPILxYTQSd bdvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ug43kfetvEUeCGo0p4Edd940mmuWIpGthgJ4IXm79E8=; b=Eo03SSxRcXFsMwKYDDAvRBqTZae9hxQds9MFtyvCpP5OuFJQWOhb4b8YxNsrTuRBcv 4kP0D2UEU4b8iaFMDJ0mQECqaF6Bx+WhEIaPnDxHpybImjSp7O/4hMm/QFgF/mgim5zs zm7UgelsSTRZY+V7BPu01gADNca69TF4WsHLJG0OnPO53LkYnTro/T+iepqlZS20V3sH 2evjxfFfY7v4IFqNw7gkwYyVzisJGktXKFn58ROC6BdRvTaCnPHLgXHSW83lvFTLUBir /mRxlg+/7UeXJoVHJrsBSEt9vtofOalKMh1QOFv6UjIO4iW6pyB2c1YdTJLz7fq3S/S5 Afpw== X-Gm-Message-State: AEkoousNLlDb1NktT+6xTj3auNAwRr7+REbljrkCKmuEiX3XfSULgeZKIQK7TqgIrZ3ERw== X-Received: by 10.194.5.230 with SMTP id v6mr13515212wjv.92.1470942254016; Thu, 11 Aug 2016 12:04:14 -0700 (PDT) Received: from localhost.localdomain ([94.229.40.98]) by smtp.gmail.com with ESMTPSA id x6sm4001376wjk.26.2016.08.11.12.04.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 11 Aug 2016 12:04:12 -0700 (PDT) From: Andrej Krutak To: alsa-devel@alsa-project.org Date: Thu, 11 Aug 2016 21:02:27 +0200 Message-Id: <1470942147-19848-16-git-send-email-dev@andree.sk> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1470942147-19848-1-git-send-email-dev@andree.sk> References: <1470942147-19848-1-git-send-email-dev@andree.sk> Cc: Andrej Krutak Subject: [alsa-devel] [PATCH 15/15] ALSA: line6: Remove double line6_pcm_release() after failed acquire. X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP If there's an error, pcm is released in line6_pcm_acquire already. Signed-off-by: Andrej Krutak --- sound/usb/line6/pcm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c index 13b3b27..455244c 100644 --- a/sound/usb/line6/pcm.c +++ b/sound/usb/line6/pcm.c @@ -55,7 +55,6 @@ static int snd_line6_impulse_volume_put(struct snd_kcontrol *kcontrol, err = line6_pcm_acquire(line6pcm, LINE6_STREAM_IMPULSE, true); if (err < 0) { line6pcm->impulse_volume = 0; - line6_pcm_release(line6pcm, LINE6_STREAM_IMPULSE); return err; } } else {