diff mbox

sound: soc: cygnus: add depends on HAS_DMA

Message ID 1475868258-10689-1-git-send-email-scott.branden@broadcom.com (mailing list archive)
State Accepted
Commit fe3683779e0b20edf91c549bbff0d81785e1c7a0
Headers show

Commit Message

Scott Branden Oct. 7, 2016, 7:24 p.m. UTC
add depends on HAS_DMA to Kconfig.  This fixes error reported
by kbuild test robot when building for ARCH=m32r:
ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!

Signed-off-by: Scott Branden <scott.branden@broadcom.com>
---
 sound/soc/bcm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Scott Branden Nov. 1, 2016, 5:53 p.m. UTC | #1
Hi Takashi/Jaroslav,

Could you pick up this patch?

On 16-10-08 01:26 PM, Ray Jui wrote:
> Hi Scott,
>
> On 10/7/2016 12:24 PM, Scott Branden wrote:
>> add depends on HAS_DMA to Kconfig.  This fixes error reported
>> by kbuild test robot when building for ARCH=m32r:
>> ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!
>>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>>   sound/soc/bcm/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig
>> index d528aac..edf3671 100644
>> --- a/sound/soc/bcm/Kconfig
>> +++ b/sound/soc/bcm/Kconfig
>> @@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
>>   config SND_SOC_CYGNUS
>>       tristate "SoC platform audio for Broadcom Cygnus chips"
>>       depends on ARCH_BCM_CYGNUS || COMPILE_TEST
>> +    depends on HAS_DMA
>>       help
>>         Say Y if you want to add support for ASoC audio on Broadcom
>>         Cygnus chips (bcm958300, bcm958305, bcm911360)
> Looks good to me.
>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>

Thanks,
  Scott
Mark Brown Nov. 2, 2016, 8:22 p.m. UTC | #2
On Tue, Nov 01, 2016 at 10:53:21AM -0700, Scott Branden wrote:
> Hi Takashi/Jaroslav,
> 
> Could you pick up this patch?

Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.
diff mbox

Patch

diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig
index d528aac..edf3671 100644
--- a/sound/soc/bcm/Kconfig
+++ b/sound/soc/bcm/Kconfig
@@ -11,6 +11,7 @@  config SND_BCM2835_SOC_I2S
 config SND_SOC_CYGNUS
 	tristate "SoC platform audio for Broadcom Cygnus chips"
 	depends on ARCH_BCM_CYGNUS || COMPILE_TEST
+	depends on HAS_DMA
 	help
 	  Say Y if you want to add support for ASoC audio on Broadcom
 	  Cygnus chips (bcm958300, bcm958305, bcm911360)