From patchwork Thu Jan 26 20:05:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 9540249 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4F6FD60429 for ; Thu, 26 Jan 2017 22:52:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4385B20649 for ; Thu, 26 Jan 2017 22:52:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 363C9282F5; Thu, 26 Jan 2017 22:52:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 749BA20649 for ; Thu, 26 Jan 2017 22:52:41 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id D0FCF267814; Thu, 26 Jan 2017 23:52:37 +0100 (CET) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 362872677B2; Thu, 26 Jan 2017 23:50:19 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id AF75E2677A4; Thu, 26 Jan 2017 21:06:10 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by alsa0.perex.cz (Postfix) with ESMTP id D7A1F267796 for ; Thu, 26 Jan 2017 21:06:08 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP; 26 Jan 2017 12:06:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,291,1477983600"; d="scan'208";a="58612540" Received: from pbossart-mobl3.an.intel.com (HELO pbossart-mobl3.intel.com) ([10.255.71.40]) by fmsmga006.fm.intel.com with ESMTP; 26 Jan 2017 12:06:06 -0800 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org Date: Thu, 26 Jan 2017 14:05:39 -0600 Message-Id: <1485461141-14023-4-git-send-email-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1485461141-14023-1-git-send-email-pierre-louis.bossart@linux.intel.com> References: <1485461141-14023-1-git-send-email-pierre-louis.bossart@linux.intel.com> Cc: tiwai@suse.de, Daniel Vetter , Pierre-Louis Bossart , Jani Nikula , broonie@kernel.org, jerome.anand@intel.com, =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Subject: [alsa-devel] [RFC PATCH 3/5] ALSA: x86: intel_hdmi: set config bitfields for DP mode X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP These bits were set in legacy and not in upstream code, and are apparently tested for when writing a config in DP mode FIXME: is this even needed? Signed-off-by: Pierre-Louis Bossart --- sound/x86/intel_hdmi_audio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c index 4155b38..768e6e3 100644 --- a/sound/x86/intel_hdmi_audio.c +++ b/sound/x86/intel_hdmi_audio.c @@ -396,6 +396,7 @@ static int snd_intelhad_prog_audio_ctrl_v2(struct snd_pcm_substream *substream, else cfg_val.cfg_regx_v2.layout = LAYOUT1; + cfg_val.cfg_regx_v2.val_bit = 1; had_write_register(AUD_CONFIG, cfg_val.cfg_regval); return 0; } @@ -447,6 +448,7 @@ static int snd_intelhad_prog_audio_ctrl_v1(struct snd_pcm_substream *substream, } + cfg_val.cfg_regx.val_bit = 1; had_write_register(AUD_CONFIG, cfg_val.cfg_regval); return 0; }