From patchwork Fri Jan 27 23:35:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergej Sawazki X-Patchwork-Id: 9542879 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7084060429 for ; Fri, 27 Jan 2017 23:38:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E27027F93 for ; Fri, 27 Jan 2017 23:38:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4F29927FBB; Fri, 27 Jan 2017 23:38:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 891BD27F93 for ; Fri, 27 Jan 2017 23:38:51 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 01E2D267BA5; Sat, 28 Jan 2017 00:38:49 +0100 (CET) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 28F92267B9B; Sat, 28 Jan 2017 00:36:31 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BBB60267B9B; Sat, 28 Jan 2017 00:36:22 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by alsa0.perex.cz (Postfix) with ESMTP id B5062267B7C for ; Sat, 28 Jan 2017 00:36:19 +0100 (CET) Received: from duke.fritz.box ([91.35.174.235]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LvDpe-1cNjsu1jXu-010JVS; Sat, 28 Jan 2017 00:36:10 +0100 From: Sergej Sawazki To: broonie@kernel.org, lgirdwood@gmail.com, ckeepax@opensource.wolfsonmicro.com Date: Sat, 28 Jan 2017 00:35:45 +0100 Message-Id: <1485560145-12908-1-git-send-email-ce3a@gmx.de> X-Mailer: git-send-email 2.7.4 X-Provags-ID: V03:K0:klEOOEGrdUQ+nJxMJvXnUxx/SQO51TNr0TnIkiSwLSUNKFDln59 bQBve35gUgH+Zm5BNYIdi7G7uR5w9TprBAt5mLf+xay+gRZcX7DJb7HUHqN1XdetWEaM7TW 1uVlXnR4VRPBFEP0GJsayWBGMnoAQVWSP5/I7Nd4qb5vDsAiqWw3/I4zapiFQr5DUJJskLA G6OH2N/xi19XWWIC6EZYg== X-UI-Out-Filterresults: notjunk:1; V01:K0:WZjYQH+DiUI=:npmenoeg5SQQpreTYHt1bp TrXO8at/aj7YfjOC7ISwZlkaslJNPbjz9gQTX5ke0XAkkHfusqPI3rZ4bnOz0wutpK9E82Q5T zqAXuzkE7tjhSUvu81PJG6UCYcTJPc4Cw1QvCVeAbkB4jX3j3fuZw0D8CLMXgsY/KyrS9j4tJ QJ9P04vUMer9jHqu+xZJ3Lpi8Ud4zU3TTaDsnLJXAyMComkSX7JE6SSOEVnlXIn1n6Lwg4i77 meZrHGGzGwROBj02wxC5Bt94l42rMyhff6+XherqkIQIC4RUVesxRC6ggQLgEcMy+scrIueMC xtnUKWUZmk5qfxfNRhlw9/qw22qf50rqO9aCMsJ9grK7RPF+g5Q59hsooSZholkonmCmbCiWL AXPIRwKq3JAHlNjyKc5/p04kI0lhWWE2L8Tea7HEJXy6RcbiQUv9iGoYGHRjnUck4kyE9CzCJ pmAuETMj8bBVF30x58xk2oP9CgGfCz6ryvcQ45hRDLeLx2bhH4cH5rfukW5S4z4h/rJJxenWI 9rWpq4LpxckFhLzMp+4ufFfIwu5WB36sceYtexCxpz3Q4VkzWRZGO8oEMnpTyNzWDTxFx/XPp MyAyY+enpUc7ncZwKPkTqmI36Wg/9AgsvpoDRkf76FIkqu5SlBAGhQcNhO7y9qcrSx5a8WvRY XdQA1yeaUnB/mKzcB5INWQknwx8lW3LC0hpC4CHutcQ7m3Xhu2hRTK9e1fHrdcUBgNRwSAoNk ySdzQVJzi5FWVoN9GteFN+tS09vcqqTwROD/gH5cocmq6TmEuLzgDw2vLx7aV3Mwtpv1Hns28 bMJyHWwEqHDigGzqjSc5hiMFJWSlSh39aDbpY+EfYYnucQEYVewcv6ly4k87lfhqyNXDGcX+W fI8EZ0R/CRD4nU3SitVD0c5OQ0BRnfbNJEQjx2i6Ywf2EywPVUhADpZz5d4sXZBhcNCWQQW7d wkhR0H3r+dVXbdMBdR7jNNOQGqemyelh56r5P9iqJ2JLueoElUH0f6BVlOuXCYbu1FwDe5AQ2 Bg== Cc: Sergej Sawazki , alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com Subject: [alsa-devel] [PATCH] ASoC: wm8741: Remove unneeded startup() callback X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Do not apply rate constraints in the startup() callback. The machine driver can change the sysclk and hence the supported frame rates in its hw_params(). This callback is unneeded since commit e369bd006fd6 ("ASoC: wm8741: Allow master clock switching"). Signed-off-by: Sergej Sawazki --- sound/soc/codecs/wm8741.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c index b8c1940..d6e540a 100644 --- a/sound/soc/codecs/wm8741.c +++ b/sound/soc/codecs/wm8741.c @@ -176,20 +176,6 @@ static const struct snd_pcm_hw_constraint_list constraints_36864 = { .list = rates_36864, }; -static int wm8741_startup(struct snd_pcm_substream *substream, - struct snd_soc_dai *dai) -{ - struct snd_soc_codec *codec = dai->codec; - struct wm8741_priv *wm8741 = snd_soc_codec_get_drvdata(codec); - - if (wm8741->sysclk) - snd_pcm_hw_constraint_list(substream->runtime, 0, - SNDRV_PCM_HW_PARAM_RATE, - wm8741->sysclk_constraints); - - return 0; -} - static int wm8741_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) @@ -360,7 +346,6 @@ static int wm8741_set_dai_fmt(struct snd_soc_dai *codec_dai, SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) static const struct snd_soc_dai_ops wm8741_dai_ops = { - .startup = wm8741_startup, .hw_params = wm8741_hw_params, .set_sysclk = wm8741_set_dai_sysclk, .set_fmt = wm8741_set_dai_fmt,