From patchwork Thu Jun 29 03:41:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Hsu X-Patchwork-Id: 9815895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 85A7360365 for ; Thu, 29 Jun 2017 03:48:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DC6E27E71 for ; Thu, 29 Jun 2017 03:48:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 626B427F90; Thu, 29 Jun 2017 03:48:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DA9527E71 for ; Thu, 29 Jun 2017 03:48:13 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id E71BF267224; Thu, 29 Jun 2017 05:41:47 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id AA9C3267261; Thu, 29 Jun 2017 05:41:46 +0200 (CEST) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by alsa0.perex.cz (Postfix) with ESMTP id 9C31626720E for ; Thu, 29 Jun 2017 05:41:44 +0200 (CEST) Received: by mail-pf0-f194.google.com with SMTP id z6so11350938pfk.3 for ; Wed, 28 Jun 2017 20:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Daj5stgAWlxFxnVMxdUcsVZURVC+QGYaV7CyLeFYGfI=; b=QhGr32VerNnmDpGSQyVjAF5a3ar71UJT+wjWWYqe2yqQh+5IK6Nt4paGEDgfgHXpQ8 11pe0S+GWv1/7QuRW44loYoGpAgt3DuhvbLpTRG3W7TfbZZPM/ElHUJfJ94ZaDai0+5m oN10W1ps7gxkYz2AU9xM0FoE3pcLFJ/joxxrte7ENm5FLKaDbI1gB+K3c8UrLOhkzUYi vsj7O4bC2vnjOPp4cmEU9agjWmwUwoq4Hl8ma+bxsoTPksKNR4ospLIAwy28fdsw/heb 25daKGBMQy9nM4YlWPPV1dCy6YV9ZaSyWLeysPdy55VB4HrzIbRkZrSLKP/8fA0FfYqF P5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Daj5stgAWlxFxnVMxdUcsVZURVC+QGYaV7CyLeFYGfI=; b=eohs90TuDISGQDdN6mwh0xLfviRxzq3xMAyWPwB+dCKWlrfHv7jRmb9L8hC1M7hrf4 HeY4KfGFQLJPGc1tZDXDskZloyRLItcMoyvKkXWUq0i82Ssm3KlwLzDhDE3cjtsSVKyf wlhRkEKahIPq4Tha5APNmdTCCRuot81g5owiz0+b+Z+s4/EmffWxdIi4ENXkgZaIiEpj zHCjfb6J/IS8ZxLmP0k0Sl9rQbXMjMZs2llDav0QKLpd5ey4pJFtWfsRvdXd/Y44GSj1 6Mw/41iB5tdvguP/+R7facso1dv+TnKNu/IcWZNiJlAwnvz8rKfD9j/wbt0sJwyU80ct 20Hw== X-Gm-Message-State: AKS2vOzT/jPGTKaKpiWoP6rneTHJSWDPPvMlqSbTBUX0hTQPOGTIy2te mL5dyXGldHf5zw== X-Received: by 10.99.171.66 with SMTP id k2mr13863025pgp.248.1498707702730; Wed, 28 Jun 2017 20:41:42 -0700 (PDT) Received: from localhost.localdomain ([202.39.226.12]) by smtp.gmail.com with ESMTPSA id z71sm7723299pfd.45.2017.06.28.20.41.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Jun 2017 20:41:41 -0700 (PDT) From: John Hsu X-Google-Original-From: John Hsu To: broonie@kernel.org Date: Thu, 29 Jun 2017 11:41:30 +0800 Message-Id: <1498707690-3978-1-git-send-email-KCHSU0@nuvoton.com> X-Mailer: git-send-email 2.6.4 Cc: alsa-devel@alsa-project.org, anatol.pomozov@gmail.com, YHCHuang@nuvoton.com, John Hsu , lgirdwood@gmail.com, benzh@chromium.org, mac.chiang@intel.com, CTLIN0@nuvoton.com, mhkuo@nuvoton.com, John Hsu , yong.zhi@intel.com Subject: [alsa-devel] [PATCH] ASoC: nau8825: change crosstalk-bypass property to bool type X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The property type of "nuvoton,crosstalk-bypass" changes to boolean. The document is updated as well. Signed-off-by: John Hsu Signed-off-by: John Hsu --- Documentation/devicetree/bindings/sound/nau8825.txt | 3 +++ sound/soc/codecs/nau8825.c | 8 ++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/nau8825.txt b/Documentation/devicetree/bindings/sound/nau8825.txt index d337423..2f5e973 100644 --- a/Documentation/devicetree/bindings/sound/nau8825.txt +++ b/Documentation/devicetree/bindings/sound/nau8825.txt @@ -69,6 +69,8 @@ Optional properties: - nuvoton,jack-insert-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms - nuvoton,jack-eject-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms + - nuvoton,crosstalk-bypass: make crosstalk function bypass if set. + - clocks: list of phandle and clock specifier pairs according to common clock bindings for the clocks described in clock-names - clock-names: should include "mclk" for the MCLK master clock @@ -96,6 +98,7 @@ Example: nuvoton,short-key-debounce = <2>; nuvoton,jack-insert-debounce = <7>; nuvoton,jack-eject-debounce = <7>; + nuvoton,crosstalk-bypass; clock-names = "mclk"; clocks = <&tegra_car TEGRA210_CLK_CLK_OUT_2>; diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index a8c7a55..46a30ea 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -2440,6 +2440,8 @@ static void nau8825_print_device_properties(struct nau8825 *nau8825) nau8825->jack_insert_debounce); dev_dbg(dev, "jack-eject-debounce: %d\n", nau8825->jack_eject_debounce); + dev_dbg(dev, "crosstalk-bypass: %d\n", + nau8825->xtalk_bypass); } static int nau8825_read_device_properties(struct device *dev, @@ -2504,10 +2506,8 @@ static int nau8825_read_device_properties(struct device *dev, &nau8825->jack_eject_debounce); if (ret) nau8825->jack_eject_debounce = 0; - ret = device_property_read_u32(dev, "nuvoton,crosstalk-bypass", - &nau8825->xtalk_bypass); - if (ret) - nau8825->xtalk_bypass = 1; + nau8825->xtalk_bypass = device_property_read_bool(dev, + "nuvoton,crosstalk-bypass"); nau8825->mclk = devm_clk_get(dev, "mclk"); if (PTR_ERR(nau8825->mclk) == -EPROBE_DEFER) {