diff mbox

Documentation: DT bindings: Add chip compatible string for audio codec.

Message ID 1506190523-4338-1-git-send-email-shreeya.patel23498@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shreeya Patel Sept. 23, 2017, 6:15 p.m. UTC
This patch adds chip compatible string to remove the warnings
generated by checkpatch that -DT compatible string
"toshiba,apb-dummy-codec" appears un-documented.

Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
---
 Documentation/devicetree/bindings/sound/sirf-audio-codec.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Mark Brown Sept. 25, 2017, 3:57 p.m. UTC | #1
On Sat, Sep 23, 2017 at 11:45:23PM +0530, Shreeya Patel wrote:
> This patch adds chip compatible string to remove the warnings
> generated by checkpatch that -DT compatible string
> "toshiba,apb-dummy-codec" appears un-documented.

What is this device and why does it make sense to be covered with this
compatible string?  The -dummy-codec makes it seem like something that
has no place in a DT at all.

Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt b/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
index 062f5ec..a61560b 100644
--- a/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
+++ b/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
@@ -3,6 +3,7 @@  SiRF internal audio CODEC
 Required properties:
 
   - compatible : "sirf,atlas6-audio-codec" or "sirf,prima2-audio-codec"
+		 "toshiba,apb-dummy-codec"
 
   - reg : the register address of the device.
 
@@ -11,7 +12,7 @@  Required properties:
 Example:
 
 audiocodec: audiocodec@b0040000 {
-	compatible = "sirf,atlas6-audio-codec";
+	compatible = "sirf,atlas6-audio-codec", "toshiba,apb-dummy-codec";
 	reg = <0xb0040000 0x10000>;
 	clocks = <&clks 27>;
 };