diff mbox

ASoC: img-parallel-out: Add pm_runtime_get/put to set_fmt callback

Message ID 1506938433-681-1-git-send-email-ed.blake@sondrel.com (mailing list archive)
State Accepted
Commit c70458890ff15d858bd347fa9f563818bcd6e457
Headers show

Commit Message

Ed Blake Oct. 2, 2017, 10 a.m. UTC 
Add pm_runtime_get_sync and pm_runtime_put calls to set_fmt callback
function. This fixes a bus error during boot when CONFIG_SUSPEND is
defined when this function gets called while the device is runtime
disabled and device registers are accessed while the clock is disabled.

Signed-off-by: Ed Blake <ed.blake@sondrel.com>
---
 sound/soc/img/img-parallel-out.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Mark Brown Oct. 4, 2017, 10:39 a.m. UTC | #1 
On Mon, Oct 02, 2017 at 11:00:33AM +0100, Ed Blake wrote:

> +	pm_runtime_get_sync(prl->dev);

I'll apply this since the driver already has runtime PM and it makes
things better but please in a followup patch add error handling.
diff mbox

Patch

diff --git a/sound/soc/img/img-parallel-out.c b/sound/soc/img/img-parallel-out.c
index 23b0f0f..2fc8a63 100644
--- a/sound/soc/img/img-parallel-out.c
+++ b/sound/soc/img/img-parallel-out.c
@@ -164,9 +164,11 @@  static int img_prl_out_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
 		return -EINVAL;
 	}
 
+	pm_runtime_get_sync(prl->dev);
 	reg = img_prl_out_readl(prl, IMG_PRL_OUT_CTL);
 	reg = (reg & ~IMG_PRL_OUT_CTL_EDGE_MASK) | control_set;
 	img_prl_out_writel(prl, reg, IMG_PRL_OUT_CTL);
+	pm_runtime_put(prl->dev);
 
 	return 0;
 }