| Message ID | 1521185527-164406-1-git-send-email-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 822e70a8210b7038e1f54c43ca6c76c3b9f89803 |
| Headers | show |
On Fri, Mar 16, 2018 at 07:32:07AM +0000, Wei Yongjun wrote: > Since the remove callback is removed, the snd_soc_unregister_component() > is missing when remove device. Using devm_snd_soc_register_component() > instead of snd_soc_register_component(). > > Fixes: 10dc44c6462d ("ASoC: wm8400: replace codec to component") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- Thanks for spotting this. Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
Hi Wei > Since the remove callback is removed, the snd_soc_unregister_component() > is missing when remove device. Using devm_snd_soc_register_component() > instead of snd_soc_register_component(). > > Fixes: 10dc44c6462d ("ASoC: wm8400: replace codec to component") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- Thank you for your patch Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Best regards --- Kuninori Morimoto
diff --git a/sound/soc/codecs/wm8400.c b/sound/soc/codecs/wm8400.c index c237365..57b2206 100644 --- a/sound/soc/codecs/wm8400.c +++ b/sound/soc/codecs/wm8400.c @@ -1343,7 +1343,7 @@ static void wm8400_component_remove(struct snd_soc_component *component) static int wm8400_probe(struct platform_device *pdev) { - return snd_soc_register_component(&pdev->dev, + return devm_snd_soc_register_component(&pdev->dev, &soc_component_dev_wm8400, &wm8400_dai, 1); }
Since the remove callback is removed, the snd_soc_unregister_component() is missing when remove device. Using devm_snd_soc_register_component() instead of snd_soc_register_component(). Fixes: 10dc44c6462d ("ASoC: wm8400: replace codec to component") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- sound/soc/codecs/wm8400.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)