diff mbox series

[v2] ASoC: Intel: Skylake: enable S24_LE format support

Message ID 1553346610-1012-1-git-send-email-jenny.tc@intel.corp-partner.google.com (mailing list archive)
State New, archived
Headers show
Series [v2] ASoC: Intel: Skylake: enable S24_LE format support | expand

Commit Message

Jenny TC March 23, 2019, 1:10 p.m. UTC 
From: Jenny TC <jenny.tc@intel.com>

To enable S24_LE format, sample_type in topology fw has to be set to 1.
But sample_type defined in topology firmware configuration is not
getting reflected in the dsp param. This patch sets sample_type in base
config so that the sample type defined in the topology firmware is reflected
in the dsp params. This issues was uncovered while debugging the S24_LE format
which require the MSB byte in 32 bit word to be skipped. Setting sample_type
in topology firmware to 1 helps to skip MSB byte word.

Signed-off-by: Jenny TC <jenny.tc@intel.com>
---
 sound/soc/intel/skylake/skl-messages.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pierre-Louis Bossart March 23, 2019, 1:39 p.m. UTC | #1 
On 3/23/19 9:10 AM, Jenny TC wrote:
> From: Jenny TC <jenny.tc@intel.com>
> 
> To enable S24_LE format, sample_type in topology fw has to be set to 1.
> But sample_type defined in topology firmware configuration is not
> getting reflected in the dsp param. This patch sets sample_type in base
> config so that the sample type defined in the topology firmware is reflected
> in the dsp params. This issues was uncovered while debugging the S24_LE format
> which require the MSB byte in 32 bit word to be skipped. Setting sample_type
> in topology firmware to 1 helps to skip MSB byte word.
> 
> Signed-off-by: Jenny TC <jenny.tc@intel.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>   sound/soc/intel/skylake/skl-messages.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
> index 28c4806..4bf70b4 100644
> --- a/sound/soc/intel/skylake/skl-messages.c
> +++ b/sound/soc/intel/skylake/skl-messages.c
> @@ -483,6 +483,7 @@ static void skl_set_base_module_format(struct skl_sst *ctx,
>   	base_cfg->audio_fmt.bit_depth = format->bit_depth;
>   	base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth;
>   	base_cfg->audio_fmt.ch_cfg = format->ch_cfg;
> +	base_cfg->audio_fmt.sample_type = format->sample_type;
>   
>   	dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n",
>   			format->bit_depth, format->valid_bit_depth,
>
diff mbox series

Patch

diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index 28c4806..4bf70b4 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -483,6 +483,7 @@  static void skl_set_base_module_format(struct skl_sst *ctx,
 	base_cfg->audio_fmt.bit_depth = format->bit_depth;
 	base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth;
 	base_cfg->audio_fmt.ch_cfg = format->ch_cfg;
+	base_cfg->audio_fmt.sample_type = format->sample_type;
 
 	dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n",
 			format->bit_depth, format->valid_bit_depth,