diff mbox series

[2/2] dt-bindings: mediatek: mt8192: add ul-delay-ms property

Message ID 1603521686-13036-3-git-send-email-jiaxin.yu@mediatek.com
State New, archived
Headers show
Series ASoC: mt6359: skip first time data at the beginning of DMIC recording | expand

Commit Message

Jiaxin Yu Oct. 24, 2020, 6:41 a.m. UTC
We can choose to drop any length of data from the beginning according
accroding 'ul-delay-ms'.

Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
---
 Documentation/devicetree/bindings/sound/mt6359.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring Oct. 30, 2020, 6:23 p.m. UTC | #1
On Sat, Oct 24, 2020 at 02:41:26PM +0800, Jiaxin Yu wrote:
> We can choose to drop any length of data from the beginning according
> accroding 'ul-delay-ms'.
> 
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> ---
>  Documentation/devicetree/bindings/sound/mt6359.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/mt6359.yaml b/Documentation/devicetree/bindings/sound/mt6359.yaml
> index a54f466f769d4..fd2d02c97fe7c 100644
> --- a/Documentation/devicetree/bindings/sound/mt6359.yaml
> +++ b/Documentation/devicetree/bindings/sound/mt6359.yaml
> @@ -49,6 +49,11 @@ properties:
>      description: |
>        Specifies the type of mic type connected to adc2
>  
> +  mediatek,ul-delay-ms:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Skip first time data at the beginning of DMIC recording

What does 'ul' mean? Nothing tells me this is DMIC related in the name 
and 'ul' is not used anywhere in the description.

> +
>  additionalProperties: false
>  
>  examples:
> @@ -56,6 +61,7 @@ examples:
>      mt6359codec: mt6359codec {
>        mediatek,dmic-mode = <0>;
>        mediatek,mic-type-0 = <2>;
> +      mediatek,ul-delay-ms = <50>;
>      };
>  
>  ...
> -- 
> 2.18.0
Tzung-Bi Shih Oct. 31, 2020, 11:38 a.m. UTC | #2
On Sat, Oct 31, 2020 at 2:23 AM Rob Herring <robh@kernel.org> wrote:
> On Sat, Oct 24, 2020 at 02:41:26PM +0800, Jiaxin Yu wrote:
> > +  mediatek,ul-delay-ms:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: |
> > +      Skip first time data at the beginning of DMIC recording
>
> What does 'ul' mean? Nothing tells me this is DMIC related in the name
> and 'ul' is not used anywhere in the description.

UL stands for Up-Link.

Please ignore the patch series.  We won't implement the delay in
mt6359.c.  Instead, we'll leverage generic dmic.c.  See
https://patchwork.kernel.org/project/alsa-devel/patch/1603521686-13036-2-git-send-email-jiaxin.yu@mediatek.com/#23716495
for previous discussion.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/mt6359.yaml b/Documentation/devicetree/bindings/sound/mt6359.yaml
index a54f466f769d4..fd2d02c97fe7c 100644
--- a/Documentation/devicetree/bindings/sound/mt6359.yaml
+++ b/Documentation/devicetree/bindings/sound/mt6359.yaml
@@ -49,6 +49,11 @@  properties:
     description: |
       Specifies the type of mic type connected to adc2
 
+  mediatek,ul-delay-ms:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: |
+      Skip first time data at the beginning of DMIC recording
+
 additionalProperties: false
 
 examples:
@@ -56,6 +61,7 @@  examples:
     mt6359codec: mt6359codec {
       mediatek,dmic-mode = <0>;
       mediatek,mic-type-0 = <2>;
+      mediatek,ul-delay-ms = <50>;
     };
 
 ...