From patchwork Thu Feb 25 18:06:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12104653 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A744CC433E0 for ; Thu, 25 Feb 2021 18:08:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9D4964F3D for ; Thu, 25 Feb 2021 18:08:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9D4964F3D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B66951675; Thu, 25 Feb 2021 19:07:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B66951675 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614276515; bh=96qwSzlHZcvcA0o1NyC+sdolrRgJiHCaqC/S5iEvO4c=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r6oJzA8TcHhXHPJH0vI6TN+CehXB+KzzUPyOxR6RgWMQJhrAi/H01vsrLhNjyqR0d ArgKcpLfdS2m4HbxLYsLq/lQFW96YJKUXkLWxVNugMIeWWPQbgLuotFNYrNyPJdMxF cqN9xcdDBGtgm8wT+HbyzF1WY6QFZP0lRndDT+PY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7A1CBF80169; Thu, 25 Feb 2021 19:06:56 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CC557F8016D; Thu, 25 Feb 2021 19:06:54 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 233B2F80169 for ; Thu, 25 Feb 2021 19:06:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 233B2F80169 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="rjwIH2Ek" Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 25 Feb 2021 10:06:39 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Feb 2021 18:06:38 +0000 Received: from audio.nvidia.com (172.20.145.6) by mail.nvidia.com (172.20.187.13) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 25 Feb 2021 18:06:36 +0000 From: Sameer Pujar To: , Subject: [RFC PATCH 1/5] ASoC: soc-component: Fix return value of snd_soc_component_set_pll() Date: Thu, 25 Feb 2021 23:36:00 +0530 Message-ID: <1614276364-13655-2-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1614276364-13655-1-git-send-email-spujar@nvidia.com> References: <1614276364-13655-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1614276399; bh=MRsEzDmf7J4bxm3LNb2m3+5Sy3ePQpn1ormjOx9bR/Y=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Type; b=rjwIH2EkYa0ZBOPnaNJu7vhjIgmBT2tQ8vnw6WoTJB9a5ab17z4EgJSmbwECxUM4O FpxT9CjPwJQRe001VBcNuN4szeZscfAf92f5sekbJYkU2AaWe02c8AErvX7C9DVKQd FxS35NvFyuprX6GiJ7HcsTvXVut34PGx4PDRxfgua7ZXxMOnVMjQCLjchyDYtHJabB SB4ApQEEvW5UxhECAlmf94Nfah26k5+sVHSYll3BejpAbSV9triIpPCB3ZOSYwtVJe 7FPubV607Hul0rT4/1tO6uYwZnd9QlAv6LhqnSTy6eoQqcb1HV+8Qxoyy26WbXZRrm mUmC4Lr+xT0Pw== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, Sameer Pujar , linux-kernel@vger.kernel.org, jonathanh@nvidia.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" snd_soc_component_set_pll() returns "-EINVAL" and prints following error if a component does not implement set_pll() callback exposed by the component driver. This happens when snd_soc_dai_set_sysclk() is invoked, which in turn calls snd_soc_component_set_pll(). "ASoC: error at snd_soc_dai_set_pll on xxx: -22" Above is not necessary because a component may not need additional configuration and chooses to not implement this. Fix this by changing default return value to "-ENOTSUPP" and driver code which invokes snd_soc_component_set_pll() can ignore this error. Signed-off-by: Sameer Pujar --- sound/soc/soc-component.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c index 159bf88..fd04e75 100644 --- a/sound/soc/soc-component.c +++ b/sound/soc/soc-component.c @@ -109,7 +109,7 @@ int snd_soc_component_set_pll(struct snd_soc_component *component, int pll_id, int source, unsigned int freq_in, unsigned int freq_out) { - int ret = -EINVAL; + int ret = -ENOTSUPP; if (component->driver->set_pll) ret = component->driver->set_pll(component, pll_id, source,