Realtek Alc 883 not have eapd

Commit Message

asd May 31, 2014, 8:58 p.m. UTC

Below is patch wich disable eapd.

Comments

Takashi Iwai June 2, 2014, 7:57 a.m. UTC | #1

At Sat, 31 May 2014 23:58:03 +0300,
asd wrote:
> 
> Below is patch wich disable eapd.

Does your patch fix any real problem?
The function alc_auto_setup_eapd() checks the widget capability and
turns on/off only when EAPD capability is found.  If the widget has no
EAPD caps, calling the function should be just harmless.


thanks,

Takashi


> Index: hda/patch_realtek.c
> ===================================================================
> --- hda.orig/patch_realtek.c	2014-05-13 14:33:14.000000000 +0300
> +++ hda/patch_realtek.c	2014-05-31 23:09:08.668996601 +0300
> @@ -293,8 +293,14 @@
>  static void alc_auto_init_amp(struct hda_codec *codec, int type)
>  {
>  	unsigned int tmp;
> +	
> +	if (codec->vendor_id == 0x10ec0883) {
>  
> -	alc_auto_setup_eapd(codec, true);
> +		alc_auto_setup_eapd(codec, false);
> +	} else {
> +		alc_auto_setup_eapd(codec, true);
> +		}
> +			
>  	switch (type) {
>  	case ALC_INIT_GPIO1:
>  		snd_hda_sequence_write(codec, alc_gpio1_init_verbs);
> _______________________________________________
> Alsa-devel mailing list
> [e-mail]
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Patch

Index: hda/patch_realtek.c
===================================================================
--- hda.orig/patch_realtek.c	2014-05-13 14:33:14.000000000 +0300
+++ hda/patch_realtek.c	2014-05-31 23:09:08.668996601 +0300
@@ -293,8 +293,14 @@ 
 static void alc_auto_init_amp(struct hda_codec *codec, int type)
 {
 	unsigned int tmp;
+	
+	if (codec->vendor_id == 0x10ec0883) {
 
-	alc_auto_setup_eapd(codec, true);
+		alc_auto_setup_eapd(codec, false);
+	} else {
+		alc_auto_setup_eapd(codec, true);
+		}
+			
 	switch (type) {
 	case ALC_INIT_GPIO1:
 		snd_hda_sequence_write(codec, alc_gpio1_init_verbs);