| Message ID | 1654696929-20205-2-git-send-email-quic_srivasam@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add software clock gating requirement check | expand |
On 6/8/22 09:02, Srinivasa Rao Mandadapu wrote: > Add flag in qcom_swrm_data private data structure for validating > software colck gating control requirement. typo: clock > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > drivers/soundwire/qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index a3fccf0..38c3bf5 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -181,6 +181,7 @@ struct qcom_swrm_ctrl { > struct qcom_swrm_data { > u32 default_cols; > u32 default_rows; > + bool sw_clk_gate_required; I would have used a different split between patches, where the flag and functionality is introduced, and a second patch where this flag would be set for a specific platform. > }; > > static const struct qcom_swrm_data swrm_v1_3_data = {
On 6/8/2022 9:09 PM, Pierre-Louis Bossart wrote: Thanks for Your time Pierre-Louis!!! > > On 6/8/22 09:02, Srinivasa Rao Mandadapu wrote: >> Add flag in qcom_swrm_data private data structure for validating >> software colck gating control requirement. > typo: clock Okay. Will fix. > >> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> >> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> drivers/soundwire/qcom.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c >> index a3fccf0..38c3bf5 100644 >> --- a/drivers/soundwire/qcom.c >> +++ b/drivers/soundwire/qcom.c >> @@ -181,6 +181,7 @@ struct qcom_swrm_ctrl { >> struct qcom_swrm_data { >> u32 default_cols; >> u32 default_rows; >> + bool sw_clk_gate_required; > I would have used a different split between patches, where the flag and > functionality is introduced, and a second patch where this flag would be > set for a specific platform. Okay. Will split accordingly! > >> }; >> >> static const struct qcom_swrm_data swrm_v1_3_data = {
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index a3fccf0..38c3bf5 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -181,6 +181,7 @@ struct qcom_swrm_ctrl { struct qcom_swrm_data { u32 default_cols; u32 default_rows; + bool sw_clk_gate_required; }; static const struct qcom_swrm_data swrm_v1_3_data = {