diff mbox

Plantronics DA45 cannot get freq at ep 0x4

Message ID 1712952849.47831328.1455441745316.JavaMail.zimbra@dkadioglu.de (mailing list archive)
State New, archived
Headers show

Commit Message

denk Feb. 14, 2016, 9:22 a.m. UTC 
Hi,

using the Plantronics DA45 Headset Adapter leads to many lines of cannot get freq at ep 0x4 and cannot get freq at ep 0x84. I found a similar error in the following discussion: http://www.spinics.net/lists/linux-usb/msg125029.html
I added the USB ID of the DA45, recompiled the kernel and the messages are gone. I would be happy if you could accept this simple addition made by the following patch:


If there are any questions or something missing, please ask.

Thanks in advance.
Best
denk

Comments

Takashi Iwai Feb. 15, 2016, 10:32 a.m. UTC | #1 
On Sun, 14 Feb 2016 10:22:25 +0100,
denk wrote:
> 
> Hi,
> 
> using the Plantronics DA45 Headset Adapter leads to many lines of cannot get freq at ep 0x4 and cannot get freq at ep 0x84. I found a similar error in the following discussion: http://www.spinics.net/lists/linux-usb/msg125029.html
> I added the USB ID of the DA45, recompiled the kernel and the messages are gone. I would be happy if you could accept this simple addition made by the following patch:
> 
> --- a/sound/usb/quirks.c	2015-12-15 06:41:43.000000000 +0100
> +++ b/sound/usb/quirks.c	2016-01-28 08:15:35.207785555 +0100
> @@ -1122,6 +1122,7 @@
>  	case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
>  	case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
>  	case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
> +	case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
>  		return true;
>  	}
>  	return false;
> 
> If there are any questions or something missing, please ask.

The change looks almost good, but it'd be better to put in the right
place, as the entries are in the order of ID numbers (i.e. after
045e:0779).

Please fix it and resubmit with a proper changelog text as well as
your sign-off, so that we can merge to upstream.  See
Documentation/SubmittingPatches for details.


thanks,

Takashi
diff mbox

Patch

--- a/sound/usb/quirks.c	2015-12-15 06:41:43.000000000 +0100
+++ b/sound/usb/quirks.c	2016-01-28 08:15:35.207785555 +0100
@@ -1122,6 +1122,7 @@ 
 	case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
 	case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
 	case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
+	case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
 		return true;
 	}
 	return false;