From patchwork Tue Sep 23 04:13:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Renu Tyagi X-Patchwork-Id: 4952821 X-Patchwork-Delegate: tiwai@suse.de Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F41E0BEEA5 for ; Tue, 23 Sep 2014 04:13:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 47264201BB for ; Tue, 23 Sep 2014 04:13:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 13A392015E for ; Tue, 23 Sep 2014 04:13:38 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 15686261B23; Tue, 23 Sep 2014 06:13:32 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 0123C261ACB; Tue, 23 Sep 2014 06:13:21 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7EFCD261AE4; Tue, 23 Sep 2014 06:13:19 +0200 (CEST) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by alsa0.perex.cz (Postfix) with ESMTP id 51192261AA5 for ; Tue, 23 Sep 2014 06:13:11 +0200 (CEST) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NCC00KSM6DSGG50@mailout1.samsung.com> for alsa-devel@alsa-project.org; Tue, 23 Sep 2014 13:13:04 +0900 (KST) Received: from epcpsbgx3.samsung.com ( [172.20.52.123]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 5A.F1.18484.F43F0245; Tue, 23 Sep 2014 13:13:03 +0900 (KST) X-AuditID: cbfee68f-f791c6d000004834-50-5420f34f7dc6 Received: from epmailer01 ( [203.254.219.141]) by epcpsbgx3.samsung.com (EPCPMTA) with SMTP id 5B.75.14702.E43F0245; Tue, 23 Sep 2014 13:13:02 +0900 (KST) Date: Tue, 23 Sep 2014 04:13:02 +0000 (GMT) From: Renu Tyagi To: "alsa-devel@alsa-project.org" MIME-version: 1.0 X-MTR: 20140923040642978@renu.tyagi Msgkey: 20140923040642978@renu.tyagi X-EPLocale: en_US.windows-1252 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20140923040642978@renu.tyagi X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general MIME-version: 1.0 Message-id: <18078000.60941411445581943.JavaMail.weblogic@epv6ml10> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsWyRsSkWtf/s0KIwdF1ehZXLh5icmD02PC5 iS2AMYrLJiU1J7MstUjfLoEr4+nCT4wF/zgrWjfuY21gvMHZxcjJISSgKrHg2jJGEFtCwETi 0pHzULaYxIV769m6GLmAapYySvw+eYkJpmhP80ZWiMQcRonbb6axgiRYgCa9PPsbrIhNQEti T2cPmC0s4CHRf28DC4gtImAv8f78ajYQm1lASeLxop9ANgfQIAWJ3ffMQMK8AoISJ2c+YYHY pSwxo/0eO0gJr4CKxL8ZMRBhOYklUy9DncMLVPKUBSY+7esaZghbWuL8rA1wvyz+/hgqzi9x 7PYOqF4BialnDkLVaEj0H38JNYdPYs3Ctyww9btOLWeG2XV/y1yoXgmJrS1PWCE+UZSY0v2Q HcI2kDiyaA4ruld4BZwlnj5fzQIKNgmBXg6J55MOME9gVJqFpG4WklmzkMxCVrOAkWUVo2hq QXJBcVJ6kbFecWJucWleul5yfu4mRmBqOP3vWf8OxrsHrA8xCnAwKvHweqxRCBFiTSwrrsw9 xGgKjKWJzFKiyfnABJRXEm9obGZkYWpiamxkbmmmJM67UOpnsJBAemJJanZqakFqUXxRaU5q 8SFGJg5OqQbGqWXBMpu3HV4V761X4rjVRGI1/xezYxoHzHj/3lAs/vurOe9MRHpG3/4TH7o9 29nzLydzK824KrDee5nlg3Y/19I1DRPMTsXOV0+xFJTZYVEttOrL72Npe96f/5+4JjB8wtH9 VwuOma5WenHjyexT8W/e6PW75++e+fRUQ3zy7P+zitxe2u26osRSnJFoqMVcVJwIAIVKY6wI AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGKsWRmVeSWpSXmKPExsVy+t/tXl2/zwohBvPeMVpcuXiIyYHRY8Pn JrYAxqg0m4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zByg qUoKZYk5pUChgMTiYiV9O5ui/NKSVIWM/OISW6VoQ3MjPSMDPVMjPUPTWCtDAwMjU6CahLSM pws/MRb846xo3biPtYHxBmcXIyeHkICqxIJryxhBbAkBE4k9zRtZIWwxiQv31rN1MXIB1cxh lLj9ZhpYggWo4eXZ30wgNpuAlsSezh4wW1jAQ6L/3gYWEFtEwF7i/fnVbCA2s4CSxONFP4Fs DqBBChK775mBhHkFBCVOznzCArFLWWJG+z12kBJeARWJfzNiIMJyEkumXmaCsHmBSp6ywMSn fV3DDGFLS5yftYER5uTF3x9Dxfkljt3eAdUrIDH1zEGoGg2J/uMvoebwSaxZ+JYFpn7XqeXM MLvub5kL1SshsbXlCSvEJ4oSU7ofskPYBhJHFs1hRfcKr4CzxNPnq1kmMMrOQpKahaR9FpJ2 ZDULGFlWMYqmFiQXFCelVxjrFSfmFpfmpesl5+duYgSnoWeLdzD+P299iFGAg1GJh9djjUKI EGtiWXFl7iFGCQ5mJRHekolAId6UxMqq1KL8+KLSnNTiQ4ymwDibyCwlmpwPTJF5JfGGxibm psamFgaG5uZmSuK88beSgoQE0hNLUrNTUwtSi2D6mDg4pRoYk7L82xPPtX/peSh2kCn2jezq s0vu+8z+4bKj+RFPOsNnpr163+aXF5gWri9oFsjbJHHTzIKh/kCEnPkxoRmbKqKkvq//aJqm G9Wu8/7GPVXhpl8sZZ+OAhPtIYVbDvOletL7Q4xf/177XYi/JUuyePchx2RNt77UnU9fv+KZ GnJLtDDt0DklluKMREMt5qLiRADLhnDQWQMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Cc: Takashi Iwai Subject: Re: [alsa-devel] [PATCH v2 01/11] mixer : fixed double free X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: renu.tyagi@samsung.com List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Takashi, I will prefer "renu tyagi". I cannot use git send-email from my organization. I will resubmit patches where I missed email id in signoff. Or you can see the attachments as they are fine. If any other issues I will be happy to respond. Thanks -------------------------------------------- Signed-off-by: renu tyagi --- src/mixer/mixer.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) -- 1.7.1 diff --git a/src/mixer/mixer.c b/src/mixer/mixer.c index 56e023d..eee9875 100644 --- a/src/mixer/mixer.c +++ b/src/mixer/mixer.c @@ -204,10 +204,8 @@ int snd_mixer_attach(snd_mixer_t *mixer, const char *name) if (err < 0) return err; err = snd_mixer_attach_hctl(mixer, hctl); - if (err < 0) { - snd_hctl_close(hctl); + if (err < 0) return err; - } return 0; }