| Message ID | 1950588.ErdGoiHh8p@wuerfel (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 30, 2014 at 01:43:41PM +0200, Arnd Bergmann wrote: > The wm8962 driver uses the input subsystem, but is selected by > SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, > resulting in this link error: That select shouldn't be there in the first place, I asked Nicolin to fix this when I applied the driver but he's not got round to it yet.
On Tue, Sep 30, 2014 at 05:45:10PM +0100, Mark Brown wrote: > On Tue, Sep 30, 2014 at 01:43:41PM +0200, Arnd Bergmann wrote: > > The wm8962 driver uses the input subsystem, but is selected by > > SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, > > resulting in this link error: > > That select shouldn't be there in the first place, I asked Nicolin to > fix this when I applied the driver but he's not got round to it yet. I think I might have missed something around those days, even though the 'Applied' mail seemly doesn't have any comment against this part: http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080083.html Is that possible for you to copy and paste the comments again? Thank you Nicolin
On Tue, Sep 30, 2014 at 10:42:42AM -0700, Nicolin Chen wrote: > On Tue, Sep 30, 2014 at 05:45:10PM +0100, Mark Brown wrote: > > That select shouldn't be there in the first place, I asked Nicolin to > > fix this when I applied the driver but he's not got round to it yet. > I think I might have missed something around those days, even though > the 'Applied' mail seemly doesn't have any comment against this part: > http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080083.html > Is that possible for you to copy and paste the comments again? I suspect it was on an earlier version of the patch or a cover letter; IIRC you were resending while I was reviewing.
On Wed, Oct 01, 2014 at 12:09:06AM +0100, Mark Brown wrote: > On Tue, Sep 30, 2014 at 10:42:42AM -0700, Nicolin Chen wrote: > > On Tue, Sep 30, 2014 at 05:45:10PM +0100, Mark Brown wrote: > > > > That select shouldn't be there in the first place, I asked Nicolin to > > > fix this when I applied the driver but he's not got round to it yet. > > > I think I might have missed something around those days, even though > > the 'Applied' mail seemly doesn't have any comment against this part: > > http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080083.html > > > Is that possible for you to copy and paste the comments again? > > I suspect it was on an earlier version of the patch or a cover letter; > IIRC you were resending while I was reviewing. I checked the Archive, the patch only got one version without cover letter. And this version only got one reply which is the Applied mail. I guess your earlier reply might have been swallowed somehow so I couldn't read it. Anyway, it's my fault that I didn't pay attention to the Kconfig part. The driver is initially designed for imx-cs42888, but I changed my mind to merge it with others before I sent it. And I didn't rewrite the part inside the Kconfig. Will be careful next time. And I think Fabio's suggestion/patch has no problem right? Thank you Nicolin
On Tue, Sep 30, 2014 at 04:26:18PM -0700, Nicolin Chen wrote: > I checked the Archive, the patch only got one version without cover > letter. And this version only got one reply which is the Applied mail. > I guess your earlier reply might have been swallowed somehow so I > couldn't read it. No, there were definitely at least two versions. > And I think Fabio's suggestion/patch has no problem right? That is the fix I was asking for.
On Wed, Oct 01, 2014 at 01:22:34PM +0100, Mark Brown wrote: > On Tue, Sep 30, 2014 at 04:26:18PM -0700, Nicolin Chen wrote: > > > I checked the Archive, the patch only got one version without cover > > letter. And this version only got one reply which is the Applied mail. > > I guess your earlier reply might have been swallowed somehow so I > > couldn't read it. > > No, there were definitely at least two versions. Sorry if I've really missed something. And I still can't find any other reply. I sent the patch with a RFC tag, so I wouldn't ignore any comment to it, especially the comment from you sir. > > > And I think Fabio's suggestion/patch has no problem right? > > That is the fix I was asking for. Is there any other comment against the driver you can remember? Thank you Nicolin
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 6164e78b466a..99e9386f7956 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -282,7 +282,7 @@ config SND_SOC_IMX_MC13783 config SND_SOC_FSL_ASOC_CARD tristate "Generic ASoC Sound Card with ASRC support" - depends on OF && I2C + depends on OF && I2C && INPUT select SND_SOC_IMX_AUDMUX select SND_SOC_IMX_PCM_DMA select SND_SOC_FSL_ESAI
The wm8962 driver uses the input subsystem, but is selected by SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, resulting in this link error: ERROR: "input_event" [sound/soc/codecs/snd-soc-wm8962.ko] undefined! ERROR: "input_register_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined! ERROR: "devm_input_allocate_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined! This adds an explicit Kconfig dependency to prevent this configuration from being used. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 708b4351f08 ("ASoC: fsl: Add Freescale Generic ASoC Sound Card with ASRC support")