diff mbox

[05/19] OMAPDSS: Kconfig: Add depencies and help section to OMAP4_DSS_HDMI_AUDIO

Message ID 198496d6220a13b0e8910361d969b8f978ee1398.1399884780.git.jsarha@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jyri Sarha May 12, 2014, 9:12 a.m. UTC
Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
 drivers/video/fbdev/omap2/dss/Kconfig |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Tomi Valkeinen May 16, 2014, 10:52 a.m. UTC | #1
Hi,

On 12/05/14 12:12, Jyri Sarha wrote:
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
>  drivers/video/fbdev/omap2/dss/Kconfig |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/omap2/dss/Kconfig b/drivers/video/fbdev/omap2/dss/Kconfig
> index 8921a7a..ecc2f50 100644
> --- a/drivers/video/fbdev/omap2/dss/Kconfig
> +++ b/drivers/video/fbdev/omap2/dss/Kconfig
> @@ -70,7 +70,15 @@ config OMAP4_DSS_HDMI
>  	  HDMI support for OMAP4 based SoCs.
>  
>  config OMAP4_DSS_HDMI_AUDIO
> -	bool
> +	bool "HDMI audio support for OMAP4"
> +	depends on OMAP4_DSS_HDMI
> +	depends on SND_OMAP_SOC=y || OMAP2_DSS = SND_OMAP_SOC
> +	default y
> +	help
> +	  HDMI audio support for OMAP4 based SoCs. Adds integrated
> +	  ASoC Digital Audio Interface component driver into OMAPDSS
> +	  module. Select SND_SOC_HDMI_CODEC and SND_SIMPLE_CARD with
> +	  devicetree description for full HDMI audio support.

What does "for full HDMI audio support" mean? What's the partial support? =)

 Tomi
Jyri Sarha May 16, 2014, 11:56 a.m. UTC | #2
On 05/16/2014 01:52 PM, Tomi Valkeinen wrote:
> Hi,
>
> On 12/05/14 12:12, Jyri Sarha wrote:
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> ---
>>   drivers/video/fbdev/omap2/dss/Kconfig |   10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/omap2/dss/Kconfig b/drivers/video/fbdev/omap2/dss/Kconfig
>> index 8921a7a..ecc2f50 100644
>> --- a/drivers/video/fbdev/omap2/dss/Kconfig
>> +++ b/drivers/video/fbdev/omap2/dss/Kconfig
>> @@ -70,7 +70,15 @@ config OMAP4_DSS_HDMI
>>   	  HDMI support for OMAP4 based SoCs.
>>
>>   config OMAP4_DSS_HDMI_AUDIO
>> -	bool
>> +	bool "HDMI audio support for OMAP4"
>> +	depends on OMAP4_DSS_HDMI
>> +	depends on SND_OMAP_SOC=y || OMAP2_DSS = SND_OMAP_SOC
>> +	default y
>> +	help
>> +	  HDMI audio support for OMAP4 based SoCs. Adds integrated
>> +	  ASoC Digital Audio Interface component driver into OMAPDSS
>> +	  module. Select SND_SOC_HDMI_CODEC and SND_SIMPLE_CARD with
>> +	  devicetree description for full HDMI audio support.
>
> What does "for full HDMI audio support" mean? What's the partial support? =)
>

The hdmi driver provides a digital audio interface (DAI) which can be 
used to transmit audio over the HDMI cable. The ASoC DAI component 
driver provides just that functionality. A machine, platform, and (in 
this case a dummy) codec component driver is also needed for a complete 
ALSA device functionality.

Anyway, I look into Mark's suggestion of instantiating all the necessary 
component drivers from the HDMI driver.

Best regards,
Jyri
diff mbox

Patch

diff --git a/drivers/video/fbdev/omap2/dss/Kconfig b/drivers/video/fbdev/omap2/dss/Kconfig
index 8921a7a..ecc2f50 100644
--- a/drivers/video/fbdev/omap2/dss/Kconfig
+++ b/drivers/video/fbdev/omap2/dss/Kconfig
@@ -70,7 +70,15 @@  config OMAP4_DSS_HDMI
 	  HDMI support for OMAP4 based SoCs.
 
 config OMAP4_DSS_HDMI_AUDIO
-	bool
+	bool "HDMI audio support for OMAP4"
+	depends on OMAP4_DSS_HDMI
+	depends on SND_OMAP_SOC=y || OMAP2_DSS = SND_OMAP_SOC
+	default y
+	help
+	  HDMI audio support for OMAP4 based SoCs. Adds integrated
+	  ASoC Digital Audio Interface component driver into OMAPDSS
+	  module. Select SND_SOC_HDMI_CODEC and SND_SIMPLE_CARD with
+	  devicetree description for full HDMI audio support.
 
 config OMAP5_DSS_HDMI
 	bool "HDMI support for OMAP5"