From patchwork Sat Nov 18 05:27:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10064357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EF4A160352 for ; Sat, 18 Nov 2017 05:28:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E31CB2ACC9 for ; Sat, 18 Nov 2017 05:28:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D7FC32ACD1; Sat, 18 Nov 2017 05:28:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 305BE2ACC9 for ; Sat, 18 Nov 2017 05:28:52 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1C93C267287; Sat, 18 Nov 2017 06:28:18 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B5699267287; Sat, 18 Nov 2017 06:28:16 +0100 (CET) Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by alsa0.perex.cz (Postfix) with ESMTP id CCBEB267269 for ; Sat, 18 Nov 2017 06:28:14 +0100 (CET) Received: by mail-pg0-f67.google.com with SMTP id s11so3480107pgc.5 for ; Fri, 17 Nov 2017 21:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=5+vWubTMkU4pzUJQ8sV7sz7wTwZxFRIhxjyz6m/Ye+Q=; b=qwP3pVU/YwePSSo1QujOZQ7VeSuSPLBnyChwCUIeTtuSqxNgAlG2exb4AIv0QqU9or zMmiLSuNWWqMJs+div56XmrdsyFM4ymb70xYuyvlliDFsFw2TwRF4PS+wYObYWxqsYyV Ot2EH14P2fRCImwZJOZXjCCtHIWplKHfvdCQl832KnhZZh0XLAZivpoOmY3yO0sxB79j X2p6MuDCTbR/4Y17grRBEiO683YKE3bbiL7Z418jadt39JKLqntYqPEgq29LL8QHwuaw /gy8KLXBAgAlsiNN2nZ4uLhrXJ93dxiixNxSjGNUDbGNtuOS1B1rOgRLnNl475L9xM3w i1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=5+vWubTMkU4pzUJQ8sV7sz7wTwZxFRIhxjyz6m/Ye+Q=; b=e3FxNzpiGrW9LodmAGEbpzVnmlpgV1ZL1N4vIzhQ+LMb2bbFZ1Jlh4udWBJdZcnPEE Rz+bMPgsBAMEggi0AksI8iyED7Dp8gyqcP/sK/iSdcMHSULX6jOIPUNhmThLPZdIMYmP 9DrtuUn0r8I3i6CLqbwKSLj7wZF5YHAjbO7QP4jZ0MQ5dxwSBwQ31AKyfloXI9p4S4Er +DGzBwTnzUx+zLI4gtytP/A8Oq/Dj7bPTQKHj1Fq2VDGLALThkwsnaW3XOl2sAnQX89x 6V8bEbz6EiV1k+CaVtkvHIbnrEymD3FIjyAb+Nd/CRv2eOI7CW26s2RsAuJtp3r0QD0+ 0nAQ== X-Gm-Message-State: AJaThX6g/c1P+rZkz7LxEpKVYF9k21Bn1mIMXmhdUtmzifwNauARrzCW 65Ui4ZU/3c2CD8xxl9R7I+A= X-Google-Smtp-Source: AGs4zMbsxelgTUU/3ItkamgMAVRSILhoafTWgMhkS1C2mnGPSyY28/6N6Q8x8mnpb08Y8ATWKZ6T+Q== X-Received: by 10.98.190.6 with SMTP id l6mr4425225pff.53.1510982893405; Fri, 17 Nov 2017 21:28:13 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id d15sm10559781pfj.163.2017.11.17.21.28.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 21:28:12 -0800 (PST) From: Arvind Yadav To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Sat, 18 Nov 2017 10:57:53 +0530 Message-Id: <19f8c64a4720118a6d6c4fedd5f8defa6938d1db.1510982440.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <874375c0dca41790e47b60ce30f88ab353f97b38.1510982440.git.arvind.yadav.cs@gmail.com> References: <874375c0dca41790e47b60ce30f88ab353f97b38.1510982440.git.arvind.yadav.cs@gmail.com> In-Reply-To: <874375c0dca41790e47b60ce30f88ab353f97b38.1510982440.git.arvind.yadav.cs@gmail.com> References: <874375c0dca41790e47b60ce30f88ab353f97b38.1510982440.git.arvind.yadav.cs@gmail.com> Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 3/5 v2] ASoC: nuc900: Fix platform_get_irq's error checking X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : nuc900_audio->irq_num is unsigned. so handle through signed variable. sound/soc/nuc900/nuc900-ac97.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c index b6615af..71fce7c 100644 --- a/sound/soc/nuc900/nuc900-ac97.c +++ b/sound/soc/nuc900/nuc900-ac97.c @@ -345,11 +345,10 @@ static int nuc900_ac97_drvprobe(struct platform_device *pdev) goto out; } - nuc900_audio->irq_num = platform_get_irq(pdev, 0); - if (!nuc900_audio->irq_num) { - ret = -EBUSY; + ret = platform_get_irq(pdev, 0); + if (ret < 0) goto out; - } + nuc900_audio->irq_num = ret; nuc900_ac97_data = nuc900_audio;