From patchwork Mon Aug 22 14:49:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9293875 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B1796607FF for ; Mon, 22 Aug 2016 16:37:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A2729289B0 for ; Mon, 22 Aug 2016 16:37:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9405B289C4; Mon, 22 Aug 2016 16:37:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D449D289B0 for ; Mon, 22 Aug 2016 16:37:10 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id B4F33266B2A; Mon, 22 Aug 2016 18:37:07 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 9E0FA2669FF; Mon, 22 Aug 2016 18:00:31 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4EEE42669FF; Mon, 22 Aug 2016 18:00:30 +0200 (CEST) Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by alsa0.perex.cz (Postfix) with ESMTP id B8B082675CE for ; Mon, 22 Aug 2016 16:49:20 +0200 (CEST) Received: from wuerfel.localnet ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0MAdid-1bQ4Hu1vgZ-00BsmQ; Mon, 22 Aug 2016 16:49:17 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Date: Mon, 22 Aug 2016 16:49:11 +0200 Message-ID: <2008659.grltYsYuN0@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160822121242.18827-1-pbrobinson@gmail.com> References: <20160822121242.18827-1-pbrobinson@gmail.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:29thZLeO0H4o43Tn443lV/nLb6dtnmNVBxvHQu8OxOo4OsmpP0d V/XNXLR9Qd5FEAOO6scBV9+HHA2ouQJGc80MpyYMTtSYHNrDi5Kv4v8/Lbsmb8JJcTjGCFa NuG45TJlDK+ti8LeYVDihC1DeSC8rozWnMg62WKZR6/s+Pjq4qePzjDr9n0uZWre3nNKVTb UweD2s8Rk+UsA+BuO9KwQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:AtSsQfnN53M=:OGYZR0qXFMpLdf04/B+0me Gt5ZsqihbmLFna68YXcNKDqlcpb1HxIe6by85g3VyowQAMNoKcfrp+T/Ne40rE2ZcqTfv3aVD 9/lcB+o2ObQE1YKjA7DYB5038K9LMP1oC1dTm0lnbTnfFkgGB7xFVeOhy3CAoFwq9KAO1gu4Z NerNKSJHjBs8DqdYEhisArx1NZRlAUUR6GK0jwh5e20DM6MY5ZNsP3CH0kmtcIwhy+YtGCF3M BIlHV4lmAeXEtGNUK2uWXA/5/zz4oyeXveh3DglD1S4PZ8e+2f1yIXG88tHbF5EV4vSbTSNQN rLTrHJSweLtEiHmkRN4VgGmEKxOa0ULBxtkWbyAj1yzGT7RmfGdeLZ6UR0o41JtaL9SaTE1oj CVreICepq2crVNqJiZ6zAbic001dTHIDZeL05J6Qh5UBaRrrZA9LOcYGTWnYzLlqm9bVnfeRi jOmxKNoTLaxLVC2OI6G9IhYsHLT7AYd5P303hRyVXSkQ+6AKFgMAbxQbwaIjhxu8Mk0Lo9syF x7XTiPN3anqN4IVekiflEbdWH7i7Nwe/EnsOjVddwXoiM95cn7Qjav7mcowMLaW4fgiJRNSCK ncUIcqNPJkqsqVUFjAsfcHTp19MNJT4mzR0lHRJHCQBVdtcGaCTwK/vMQSu30My4t18hqVhhe TP/9J7FSDd1aKdt9g5L4jGbRAk5rd5eJ1ObctHpZAy6SRbef6emDMd9f3ucUB583o3g22SjTn A8NdjDlmGeqjDkfe Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, wens@csie.org, broonie@kernel.org, Peter Robinson , maxime.ripard@free-electrons.com Subject: Re: [alsa-devel] [PATCH] ASoC: sunxi: depend on ARCH_SUNXI X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Monday, August 22, 2016 1:12:42 PM CEST Peter Robinson wrote: > Depend on ARCH_SUNXI or COMPILE_TEST as it doesn't make sense to enable > these if the appropriate SoC they're embedded in isn't enabled. > > Signed-off-by: Peter Robinson > --- > sound/soc/sunxi/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig > index 2a954bd..a2b62dc5 100644 > --- a/sound/soc/sunxi/Kconfig > +++ b/sound/soc/sunxi/Kconfig > @@ -2,6 +2,7 @@ menu "Allwinner SoC Audio support" > > config SND_SUN4I_CODEC > tristate "Allwinner A10 Codec Support" > + depends on ARCH_SUNXI || COMPILE_TEST > select SND_SOC_GENERIC_DMAENGINE_PCM > select REGMAP_MMIO > Makes sense, though I think it's nicer to add the dependency to the entire menu, so we hide that as well, and don't have to add the line to future entries: Either way Acked-by: Arnd Bergmann diff --git a/sound/soc/sunxi/Kconfig b/sound/soc/sunxi/Kconfig index 2a954bd01fd8..dd2368297fd3 100644 --- a/sound/soc/sunxi/Kconfig +++ b/sound/soc/sunxi/Kconfig @@ -1,4 +1,5 @@ menu "Allwinner SoC Audio support" + depends on ARCH_SUNXI || COMPILE_TEST config SND_SUN4I_CODEC tristate "Allwinner A10 Codec Support"