From patchwork Fri Feb 21 08:52:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 3695041 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B5832BF13A for ; Fri, 21 Feb 2014 08:53:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E55D42017E for ; Fri, 21 Feb 2014 08:53:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id A46A920179 for ; Fri, 21 Feb 2014 08:53:11 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 232BB265851; Fri, 21 Feb 2014 09:53:05 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id B2E172619DC; Fri, 21 Feb 2014 09:52:54 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id CF43C2619E3; Fri, 21 Feb 2014 09:52:53 +0100 (CET) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by alsa0.perex.cz (Postfix) with ESMTP id 5464B26162E for ; Fri, 21 Feb 2014 09:52:45 +0100 (CET) Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s1L8qgV1016744 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Feb 2014 08:52:42 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s1L8qeoG019608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 21 Feb 2014 08:52:41 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1L8qeg3026344; Fri, 21 Feb 2014 08:52:40 GMT Received: from elgon.mountain (/41.202.240.13) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 21 Feb 2014 00:52:39 -0800 Date: Fri, 21 Feb 2014 11:52:40 +0300 From: Dan Carpenter To: Liam Girdwood Message-ID: <20140221085240.GA13185@elgon.mountain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Cc: alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, Vinod Koul , Mark Brown Subject: [alsa-devel] [patch] ASoC: Intel: sst-firmware: missing curly braces (harmless) X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP There were some curly braces intended here, but the code actually works the same either way so it's not a bug. Signed-off-by: Dan Carpenter diff --git a/sound/soc/intel/sst-firmware.c b/sound/soc/intel/sst-firmware.c index b6f9b5ecb66a..51b56a473bc5 100644 --- a/sound/soc/intel/sst-firmware.c +++ b/sound/soc/intel/sst-firmware.c @@ -293,7 +293,7 @@ static int block_module_prepare(struct sst_module *module) /* enable each block so that's it'e ready for module P/S data */ list_for_each_entry(block, &module->block_list, module_list) { - if (block->ops && block->ops->enable) + if (block->ops && block->ops->enable) { ret = block->ops->enable(block); if (ret < 0) { dev_err(module->dsp->dev, @@ -301,6 +301,7 @@ static int block_module_prepare(struct sst_module *module) block->type, block->index); goto err; } + } } return ret;