From patchwork Tue Mar 4 09:28:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Richter X-Patchwork-Id: 3760381 X-Patchwork-Delegate: tiwai@suse.de Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4F8699F1EE for ; Tue, 4 Mar 2014 09:30:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7DCCA203DA for ; Tue, 4 Mar 2014 09:30:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id ED340201F0 for ; Tue, 4 Mar 2014 09:30:26 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id BBD40265794; Tue, 4 Mar 2014 10:30:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id F34F126575F; Tue, 4 Mar 2014 10:29:20 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id E6875265774; Tue, 4 Mar 2014 10:29:18 +0100 (CET) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by alsa0.perex.cz (Postfix) with ESMTP id C8C5C26573F for ; Tue, 4 Mar 2014 10:28:18 +0100 (CET) X-Envelope-From: stefanr@s5r6.in-berlin.de Received: from stein ([83.221.231.67]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-4) with ESMTP id s249SFgB002041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 4 Mar 2014 10:28:16 +0100 Date: Tue, 4 Mar 2014 10:28:15 +0100 From: Stefan Richter To: Jonathan Woithe Message-ID: <20140304102815.4c7428c0@stein> In-Reply-To: <20140304093323.31b314d1@stein> References: <1393558072-25926-1-git-send-email-o-takashi@sakamocchi.jp> <1393558072-25926-19-git-send-email-o-takashi@sakamocchi.jp> <20140228212535.7606e0d8@stein> <5311517B.5060905@sakamocchi.jp> <20140301111013.483fd7df@stein> <5311D0FC.7020302@sakamocchi.jp> <20140301152050.5de701a3@stein> <20140304013535.GP15773@marvin.atrad.com.au> <20140304093323.31b314d1@stein> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Mime-Version: 1.0 Cc: tiwai@suse.de, alsa-devel@alsa-project.org, ffado-devel@lists.sf.net, Takashi Sakamoto Subject: Re: [alsa-devel] [FFADO-devel] [PATCH 18/39] firewire-lib: Add a fallback at RCODE_CANCELLED X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP I wrote: >>>>> Since FFADO applies 200 ms or more as FCP >>>>> transaction timeout, shouldn't firewire-lib's fcp.c increase >>>>> FCP_TIMEOUT_MS from 125 to 200 or more as well? FFADO took over the 200 ms timeout from libavc1394, where it was introduced by this changeset: http://sourceforge.net/p/libavc1394/code/24/ Commit [r24] increase timeout Authored by: ddennedy 2002-10-01 So this was certainly not done particularly for audio devices. And interestingly, the immediate parent commit r23 on 2002-09-28 corrected the timeout from 50 ms to 100 ms. --- a/trunk/libavc1394/libavc1394/avc1394_internal.h +++ b/trunk/libavc1394/libavc1394/avc1394_internal.h @@ -8,7 +8,7 @@ #define MAX_RESPONSE_SIZE 512 #define AVC1394_RETRY 2 #define AVC1394_SLEEP 10000 -#define AVC1394_POLL_TIMEOUT 100 +#define AVC1394_POLL_TIMEOUT 200 /* #define DEBUG */ void htonl_block(quadlet_t *buf, int len);