From patchwork Wed May 28 16:42:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 4256461 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C9007BF90B for ; Wed, 28 May 2014 16:43:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 876462027D for ; Wed, 28 May 2014 16:43:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 9236B20170 for ; Wed, 28 May 2014 16:43:37 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 93A4826530E; Wed, 28 May 2014 18:43:36 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id F421F265668; Wed, 28 May 2014 18:43:20 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 8448F265668; Wed, 28 May 2014 18:43:19 +0200 (CEST) Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by alsa0.perex.cz (Postfix) with ESMTP id F1F1426530E for ; Wed, 28 May 2014 18:43:04 +0200 (CEST) Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4SGh3AM003812 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 May 2014 16:43:03 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4SGh2mA022466 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 May 2014 16:43:02 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4SGh266015977; Wed, 28 May 2014 16:43:02 GMT Received: from mwanda (/41.202.240.7) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 May 2014 09:43:01 -0700 Date: Wed, 28 May 2014 19:42:46 +0300 From: Dan Carpenter To: Clemens Ladisch Message-ID: <20140528164246.GC1824@mwanda> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Cc: alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Sakamoto Subject: [alsa-devel] [patch 2/2] ALSA: fireworks: small leak on error path X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP There was a typo here so we return directly instead of freeing "hwinfo". Signed-off-by: Dan Carpenter Tested-by: Takashi Sakamoto diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c index 8e856cc..996fdc4 100644 --- a/sound/firewire/fireworks/fireworks.c +++ b/sound/firewire/fireworks/fireworks.c @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw) /* Hardware metering. */ if (hwinfo->phys_in_grp_count > HWINFO_MAX_CAPS_GROUPS || hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) { - return -EIO; + err = -EIO; goto end; } efw->phys_in = hwinfo->phys_in;