| Message ID | 20140805120718.GA12767@himangi-Dell (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8b0276d281c9c9e62669736703c87385436a1265 |
| Delegated to: | Takashi Iwai |
| Headers | show |
At Tue, 5 Aug 2014 17:37:18 +0530, Himangi Saraogi wrote: > > This typedef is unnecessary and should just be removed as they are > never used. > > The following Coccinelle semantic patch detects the case. > > @tn@ > identifier i; > type td; > @@ > > -typedef > struct i { ... } > -td > ; > > @@ > type tn.td; > identifier tn.i; > @@ > > -td > + struct i > > Signed-off-by: Himangi Saraogi <himangi774@gmail.com> > Acked-by: Julia Lawall <julia.lawall@lip6.fr> Applied, thanks. Takashi > --- > sound/oss/opl3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/oss/opl3.c b/sound/oss/opl3.c > index 4709e59..607cee4 100644 > --- a/sound/oss/opl3.c > +++ b/sound/oss/opl3.c > @@ -52,7 +52,7 @@ struct voice_info > int panning; /* 0xffff means not set */ > }; > > -typedef struct opl_devinfo > +struct opl_devinfo > { > int base; > int left_io, right_io; > @@ -73,7 +73,7 @@ typedef struct opl_devinfo > unsigned char cmask; > > int is_opl4; > -} opl_devinfo; > +}; > > static struct opl_devinfo *devc = NULL; > > -- > 1.9.1 > 1
diff --git a/sound/oss/opl3.c b/sound/oss/opl3.c index 4709e59..607cee4 100644 --- a/sound/oss/opl3.c +++ b/sound/oss/opl3.c @@ -52,7 +52,7 @@ struct voice_info int panning; /* 0xffff means not set */ }; -typedef struct opl_devinfo +struct opl_devinfo { int base; int left_io, right_io; @@ -73,7 +73,7 @@ typedef struct opl_devinfo unsigned char cmask; int is_opl4; -} opl_devinfo; +}; static struct opl_devinfo *devc = NULL;
This typedef is unnecessary and should just be removed as they are never used. The following Coccinelle semantic patch detects the case. @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> --- sound/oss/opl3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)