From patchwork Tue Aug 5 12:07:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: HIMANGI SARAOGI X-Patchwork-Id: 4678491 X-Patchwork-Delegate: tiwai@suse.de Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 987C6C0338 for ; Tue, 5 Aug 2014 12:07:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E85E32015A for ; Tue, 5 Aug 2014 12:07:54 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 247C82014A for ; Tue, 5 Aug 2014 12:07:53 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9D93B264FFF; Tue, 5 Aug 2014 14:07:50 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 564CC261B33; Tue, 5 Aug 2014 14:07:40 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 152492625EA; Tue, 5 Aug 2014 14:07:36 +0200 (CEST) Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) by alsa0.perex.cz (Postfix) with ESMTP id 3693E2619DB for ; Tue, 5 Aug 2014 14:07:28 +0200 (CEST) Received: by mail-pd0-f174.google.com with SMTP id fp1so1243678pdb.5 for ; Tue, 05 Aug 2014 05:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=sv819HxyMCMs5+v8WmepBRkAogF28Y4cdQrFSdZ40V0=; b=IbgJo0B6R5glYP6Nj/2ZbjtdCMyGHRSiRiFiKz7Cq2XiFDsDLSDeY9Hh5xn+Cb6r91 UYLsSpKcZ8dzJ2+Vzw3gz7FqttBNt/XuWXPCOmdHFYzG6UrrJBN52wM3x2mQaLV1fEm5 xtdTzblcby/h3DovOCznMRA5w3kYZiwu6aX8WL8UZKZLPdacKMJ6vjQoQTu0fnHha6P0 oBIXmUSBAesYxBb8ZKwVbZYFf3pAC1NvrwaOUF9gBV0NC8OgsuVOWV6qa/BZoYJ0QLXX GMT+x/iLgh5jFVEQInp8eQqEPODRC1iVN6K+P7jSzdwYxd05IImn0tC0Qpi8jEr5PGzy djWg== X-Received: by 10.70.35.207 with SMTP id k15mr3675761pdj.5.1407240441822; Tue, 05 Aug 2014 05:07:21 -0700 (PDT) Received: from localhost ([14.139.82.6]) by mx.google.com with ESMTPSA id kt2sm1855362pbc.83.2014.08.05.05.07.19 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 05 Aug 2014 05:07:20 -0700 (PDT) Date: Tue, 5 Aug 2014 17:37:18 +0530 From: Himangi Saraogi To: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20140805120718.GA12767@himangi-Dell> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Cc: julia.lawall@lip6.fr Subject: [alsa-devel] [PATCH] sound/oss/opl3: Remove typedef opl_devinfo X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This typedef is unnecessary and should just be removed as they are never used. The following Coccinelle semantic patch detects the case. @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- sound/oss/opl3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/oss/opl3.c b/sound/oss/opl3.c index 4709e59..607cee4 100644 --- a/sound/oss/opl3.c +++ b/sound/oss/opl3.c @@ -52,7 +52,7 @@ struct voice_info int panning; /* 0xffff means not set */ }; -typedef struct opl_devinfo +struct opl_devinfo { int base; int left_io, right_io; @@ -73,7 +73,7 @@ typedef struct opl_devinfo unsigned char cmask; int is_opl4; -} opl_devinfo; +}; static struct opl_devinfo *devc = NULL;