| Message ID | 20140818200009.12a52dfa@songinha-Samsung-DeskTop-System (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Aug 18, 2014 at 08:00:09PM +0900, Inha Song wrote: > This patch update DT binding to support INn_MODE init_data. Each > input signal path can be configurated either as a Analogue or > Digital using the INn_MODE registers. > > Signed-off-by: Inha Song <ideal.song@samsung.com> > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > index 5c7e723..0064b21 100644 > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > @@ -42,6 +42,14 @@ Optional properties: > the chip default will be used. If present exactly five values must > be specified. > > + - wlf,inmode : A list of INn_MODE register values, where n is the number > + of input signals. Each input signal path can be configurated either as a > + Analogue or Digital using the INn_MODE registers. If absent, INn_MODE I would replace the second sentence here with something like "Valid values are 0 (Differential), 1 (Single-ended) and 2 (Digital Microphone)." Thanks, Charles > + registers set to 0 by default. If present, values must be specified less > + than or equal to the number of input singals. If values less than the > + number of input signals, elements that has not been specifed are set to 0 > + by default. > + > - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if > they are being externally supplied. As covered in > Documentation/devicetree/bindings/regulator/regulator.txt > -- > 2.0.0.390.gcb682f8 >
Hi, Charles. Thanks for your review. On Mon, 18 Aug 2014 15:29:45 +0100 Charles Keepax <ckeepax@opensource.wolfsonmicro.com> wrote: > On Mon, Aug 18, 2014 at 08:00:09PM +0900, Inha Song wrote: > > This patch update DT binding to support INn_MODE init_data. Each > > input signal path can be configurated either as a Analogue or > > Digital using the INn_MODE registers. > > > > Signed-off-by: Inha Song <ideal.song@samsung.com> > > --- > > Documentation/devicetree/bindings/mfd/arizona.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > > index 5c7e723..0064b21 100644 > > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > > @@ -42,6 +42,14 @@ Optional properties: > > the chip default will be used. If present exactly five values must > > be specified. > > > > + - wlf,inmode : A list of INn_MODE register values, where n is the number > > + of input signals. Each input signal path can be configurated either as a > > + Analogue or Digital using the INn_MODE registers. If absent, INn_MODE > > I would replace the second sentence here with something like > "Valid values are 0 (Differential), 1 (Single-ended) and 2 (Digital > Microphone)." > OK, I will fix it like this: - wlf,inmode : A list of INn_MODE register values, where n is the number of input signals. Valid values are 0 (Differential), 1 (Single-ended) and 2 (Digital Microphone). If absent, INn_MODE registers......... Best regards, Inha Song. > Thanks, > Charles > > > + registers set to 0 by default. If present, values must be specified less > > + than or equal to the number of input singals. If values less than the > > + number of input signals, elements that has not been specifed are set to 0 > > + by default. > > + > > - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if > > they are being externally supplied. As covered in > > Documentation/devicetree/bindings/regulator/regulator.txt > > -- > > 2.0.0.390.gcb682f8 > >
diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt index 5c7e723..0064b21 100644 --- a/Documentation/devicetree/bindings/mfd/arizona.txt +++ b/Documentation/devicetree/bindings/mfd/arizona.txt @@ -42,6 +42,14 @@ Optional properties: the chip default will be used. If present exactly five values must be specified. + - wlf,inmode : A list of INn_MODE register values, where n is the number + of input signals. Each input signal path can be configurated either as a + Analogue or Digital using the INn_MODE registers. If absent, INn_MODE + registers set to 0 by default. If present, values must be specified less + than or equal to the number of input singals. If values less than the + number of input signals, elements that has not been specifed are set to 0 + by default. + - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if they are being externally supplied. As covered in Documentation/devicetree/bindings/regulator/regulator.txt
This patch update DT binding to support INn_MODE init_data. Each input signal path can be configurated either as a Analogue or Digital using the INn_MODE registers. Signed-off-by: Inha Song <ideal.song@samsung.com> --- Documentation/devicetree/bindings/mfd/arizona.txt | 8 ++++++++ 1 file changed, 8 insertions(+)