From patchwork Sat Nov 8 00:38:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: NeilBrown X-Patchwork-Id: 5260051 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 531D3C11AC for ; Sun, 9 Nov 2014 09:20:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5FA192015D for ; Sun, 9 Nov 2014 09:20:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 240B020145 for ; Sun, 9 Nov 2014 09:20:57 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0BB9E2605A8; Sun, 9 Nov 2014 10:20:55 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id E2E37260513; Sun, 9 Nov 2014 10:19:20 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 242C92657C3; Sat, 8 Nov 2014 01:39:12 +0100 (CET) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D761D26044C for ; Sat, 8 Nov 2014 01:39:08 +0100 (CET) Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E2712ACF9; Sat, 8 Nov 2014 00:39:08 +0000 (UTC) From: NeilBrown To: Mark Rutland , Pawel Moll , Ian Campbell , Liam Girdwood , Rob Herring , Peter Ujfalusi , Mark Brown Date: Sat, 08 Nov 2014 11:38:03 +1100 Message-ID: <20141108003803.6561.52497.stgit@notabene.brown> In-Reply-To: <20141108002637.6561.19002.stgit@notabene.brown> References: <20141108002637.6561.19002.stgit@notabene.brown> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 09 Nov 2014 10:19:15 +0100 Cc: GTA04 owners , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 3/3] ASoC: twl4030: enable routing audio to 'voice' interface. X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP When 'voice' is some external connection, we power up the downlink when the downline amplifier is not muted, and power up the uplink when a new switch "Voice Uplink" is turned on. Signed-off-by: NeilBrown --- sound/soc/codecs/twl4030.c | 58 +++++++++++++++++++++++++++++++++----------- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index 39b6d24377e5..f51fb749087f 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -348,9 +348,9 @@ static void twl4030_init_chip(struct snd_soc_codec *codec) * tri-state until enabled */ twl4030_voice_set_codec_fmt(codec, twl4030->pdata->voice_fmt); - twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE, - TWL4030_VIF_TRI_EN, - TWL4030_REG_VOICE_IF); + /* These pins only relevant when voice_fmt set */ + snd_soc_dapm_disable_pin(&codec->dapm, "VOICEIN"); + snd_soc_dapm_disable_pin(&codec->dapm, "VOICEOUT"); } twl4030_codec_enable(codec, 0); @@ -985,15 +985,17 @@ static int snd_soc_put_twl4030_opmode_enum_double(struct snd_kcontrol *kcontrol, return -EBUSY; } if (twl4030->pdata->voice_fmt) { - /* There is no SND interface to voice, we need to control - * it here. - */ - /* If 'val' then voice is disabled, so tri-state it as well */ - snd_soc_update_bits(codec, TWL4030_REG_VOICE_IF, - TWL4030_VIF_TRI_EN, - val ? 0xff : 0); + if (val) { + /* Voice now disabled */ + snd_soc_dapm_disable_pin(&codec->dapm, "VOICEIN"); + snd_soc_dapm_disable_pin(&codec->dapm, "VOICEOUT"); + } else { + /* Voice now enabled */ + snd_soc_dapm_enable_pin(&codec->dapm, "VOICEIN"); + snd_soc_dapm_enable_pin(&codec->dapm, "VOICEOUT"); + } + snd_soc_dapm_sync(&codec->dapm); } - return snd_soc_put_enum_double(kcontrol, ucontrol); } @@ -1016,6 +1018,13 @@ static DECLARE_TLV_DB_SCALE(digital_coarse_tlv, 0, 600, 0); */ static DECLARE_TLV_DB_SCALE(digital_voice_downlink_tlv, -3700, 100, 1); +static const struct snd_kcontrol_new twl4030_dapm_vdown_control = + SOC_DAPM_SINGLE_TLV("Volume", + TWL4030_REG_VRXPGA, 0, 0x31, 0, + digital_voice_downlink_tlv); + +static const struct snd_kcontrol_new twl4030_dapm_vup_control = + SOC_DAPM_SINGLE("Switch", TWL4030_REG_VOICE_IF, 5, 1, 0); /* * Analog playback gain * -24 dB to 12 dB in 2 dB steps @@ -1126,9 +1135,6 @@ static const struct snd_kcontrol_new twl4030_snd_controls[] = { TWL4030_REG_ARXL2_APGA_CTL, TWL4030_REG_ARXR2_APGA_CTL, 1, 1, 0), - /* Common voice downlink gain controls */ - SOC_SINGLE_TLV("DAC Voice Digital Downlink Volume", - TWL4030_REG_VRXPGA, 0, 0x31, 0, digital_voice_downlink_tlv), SOC_SINGLE_TLV("DAC Voice Analog Downlink Volume", TWL4030_REG_VDL_APGA_CTL, 3, 0x12, 1, analog_tlv), @@ -1188,6 +1194,7 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = { /* Digital microphones (Stereo) */ SND_SOC_DAPM_INPUT("DIGIMIC0"), SND_SOC_DAPM_INPUT("DIGIMIC1"), + SND_SOC_DAPM_INPUT("VOICEIN"), /* Outputs */ SND_SOC_DAPM_OUTPUT("EARPIECE"), @@ -1200,6 +1207,7 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = { SND_SOC_DAPM_OUTPUT("HFL"), SND_SOC_DAPM_OUTPUT("HFR"), SND_SOC_DAPM_OUTPUT("VIBRA"), + SND_SOC_DAPM_OUTPUT("VOICEOUT"), /* AIF and APLL clocks for running DAIs (including loopback) */ SND_SOC_DAPM_OUTPUT("Virtual HiFi OUT"), @@ -1216,6 +1224,10 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = { SND_SOC_DAPM_AIF_IN("VAIFIN", "Voice Playback", 0, TWL4030_REG_VOICE_IF, 6, 0), + SND_SOC_DAPM_SUPPLY("VoiceEnable", TWL4030_REG_VOICE_IF, 6, 0, NULL, 0), + SND_SOC_DAPM_SUPPLY("VoicePlay", TWL4030_REG_OPTION, 4, 0, NULL, 0), + SND_SOC_DAPM_SUPPLY("VoiceCapture", TWL4030_REG_OPTION, 2, 0, NULL, 0), + /* Analog bypasses */ SND_SOC_DAPM_SWITCH("Right1 Analog Loopback", SND_SOC_NOPM, 0, 0, &twl4030_dapm_abypassr1_control), @@ -1395,9 +1407,27 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = { TWL4030_REG_MICBIAS_CTL, 2, 0, NULL, 0), SND_SOC_DAPM_SUPPLY("VIF Enable", TWL4030_REG_VOICE_IF, 0, 0, NULL, 0), + + SND_SOC_DAPM_SUPPLY("Voice NO-tri", TWL4030_REG_VOICE_IF, 2, 1, NULL, 0), + + SND_SOC_DAPM_SWITCH("DAC Voice Digital Downlink", SND_SOC_NOPM, + 0, 0, &twl4030_dapm_vdown_control), + SND_SOC_DAPM_SWITCH("Voice Uplink", SND_SOC_NOPM, + 0, 0, &twl4030_dapm_vup_control), }; static const struct snd_soc_dapm_route intercon[] = { + {"DAC Voice", NULL, "DAC Voice Digital Downlink"}, + {"DAC Voice", NULL, "VoiceEnable"}, + {"DAC Voice", NULL, "VoicePlay"}, + {"DAC Voice Digital Downlink", "Volume", "VOICEIN"}, + + {"VOICEOUT", NULL, "Voice Uplink"}, + {"VOICEOUT", NULL, "VoiceEnable"}, + {"VOICEOUT", NULL, "VoiceCapture"}, + {"VOICEOUT", NULL, "Voice NO-tri"}, + {"Voice Uplink", "Switch", "TX2 Capture Route"}, + /* Stream -> DAC mapping */ {"DAC Right1", NULL, "HiFi Playback"}, {"DAC Left1", NULL, "HiFi Playback"},