diff mbox

ASoC: sigmadsp: uninitialized variable in sigmadsp_activate_ctrl()

Message ID 20141126223516.GB443@mwanda (mailing list archive)
State Accepted
Commit d98123a76be53d570d72e04aac3e195a560ef149
Headers show

Commit Message

Dan Carpenter Nov. 26, 2014, 10:35 p.m. UTC 
The "changed" variable should be set to false at the start.

Fixes: a35daac77a03 ('ASoC: sigmadsp: Add support for fw v2')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Lars-Peter Clausen Nov. 27, 2014, 8:09 a.m. UTC | #1 
On 11/26/2014 11:35 PM, Dan Carpenter wrote:
> The "changed" variable should be set to false at the start.
>
> Fixes: a35daac77a03 ('ASoC: sigmadsp: Add support for fw v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.
Mark Brown Nov. 27, 2014, 10:59 a.m. UTC | #2 
On Thu, Nov 27, 2014 at 01:35:16AM +0300, Dan Carpenter wrote:
> The "changed" variable should be set to false at the start.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c
index 34fdc40..d53680a 100644
--- a/sound/soc/codecs/sigmadsp.c
+++ b/sound/soc/codecs/sigmadsp.c
@@ -661,7 +661,8 @@  static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp,
 	struct snd_card *card = sigmadsp->component->card->snd_card;
 	struct snd_kcontrol_volatile *vd;
 	struct snd_ctl_elem_id id;
-	bool active, changed;
+	bool active;
+	bool changed = false;
 
 	active = sigmadsp_samplerate_valid(ctrl->samplerates, samplerate_mask);