From patchwork Mon Mar 9 18:15:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5970541 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1CE00BF440 for ; Mon, 9 Mar 2015 18:15:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 479E220279 for ; Mon, 9 Mar 2015 18:15:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 9B70B20266 for ; Mon, 9 Mar 2015 18:15:50 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4FED62607E9; Mon, 9 Mar 2015 19:15:49 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id AD0DD2607FF; Mon, 9 Mar 2015 19:15:41 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 35672260836; Mon, 9 Mar 2015 19:15:40 +0100 (CET) Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) by alsa0.perex.cz (Postfix) with ESMTP id 713F82607FF for ; Mon, 9 Mar 2015 19:15:33 +0100 (CET) Received: by iecrl12 with SMTP id rl12so22933484iec.5 for ; Mon, 09 Mar 2015 11:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=vuWLjwPRPMWe1p9cKS9uW/xXJqM9ZVVHr3cDbO1KVF8=; b=Xe2JhHym/NTlLh+BYeCk0sumk8DnseqCa7Ed4r5J5q5ZeTP1Gb3cvfPeC57a9OkHzl ekFlhD/3ypEFhsGHRXJ2n04DmBFEvuJoqS6gF45/BqtmREqFhafo5TAqUeIiLyMco7Ai JUGIHaxkGG2vHvA49smRaw1byuJgT55/qdXFUOga1CIKD39cdOsVrsPofwDH2t16J3j6 ZJ0G66Vi8JYyDgTI5HWTq5bvN4Vzm0g/NSJJEj7pr+gOaVNEehqx9abZnKTYNImxvcjW sr+l36fv59m4NfA78bj8g7DDWNj+dJI3Tmjp/2JHb+hRKXXmS7DbUTKMXqHGXPCkVhZF pMtQ== X-Received: by 10.107.164.140 with SMTP id d12mr2878935ioj.13.1425924932241; Mon, 09 Mar 2015 11:15:32 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1301:e89d:fc51:1f84:5b7a]) by mx.google.com with ESMTPSA id e3sm116327igg.16.2015.03.09.11.15.30 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 09 Mar 2015 11:15:31 -0700 (PDT) Date: Mon, 9 Mar 2015 11:15:28 -0700 From: Dmitry Torokhov To: Mark Brown Message-ID: <20150309181528.GA26428@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Cc: alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH] ASoC: cx20442: remove incorerct __exit markups X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- sound/soc/codecs/cx20442.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c index 0b10979..0f334bc 100644 --- a/sound/soc/codecs/cx20442.c +++ b/sound/soc/codecs/cx20442.c @@ -420,7 +420,7 @@ static int cx20442_platform_probe(struct platform_device *pdev) &cx20442_codec_dev, &cx20442_dai, 1); } -static int __exit cx20442_platform_remove(struct platform_device *pdev) +static int cx20442_platform_remove(struct platform_device *pdev) { snd_soc_unregister_codec(&pdev->dev); return 0; @@ -431,7 +431,7 @@ static struct platform_driver cx20442_platform_driver = { .name = "cx20442-codec", }, .probe = cx20442_platform_probe, - .remove = __exit_p(cx20442_platform_remove), + .remove = cx20442_platform_remove, }; module_platform_driver(cx20442_platform_driver);