diff mbox

ASoC: fix simple_return.cocci warnings

Message ID 20150428042032.GA178194@athens (mailing list archive)
State Accepted
Commit fb75ee66c2707f56397eb29c01decf36254e3d46
Headers show

Commit Message

Fengguang Wu April 28, 2015, 4:20 a.m. UTC 
sound/soc/codecs/adau1977.c:496:5-8: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 adau1977.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Mark Brown April 30, 2015, 8:22 p.m. UTC | #1 
On Tue, Apr 28, 2015 at 12:20:32PM +0800, kbuild test robot wrote:
> sound/soc/codecs/adau1977.c:496:5-8: WARNING: end returns can be simpified
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci

This doesn't apply against current code either.
diff mbox

Patch

--- a/sound/soc/codecs/adau1977.c
+++ b/sound/soc/codecs/adau1977.c
@@ -493,10 +493,7 @@  static int adau1977_set_bias_level(struc
 		break;
 	}
 
-	if (ret)
-		return ret;
-
-	return 0;
+	return ret;
 }
 
 static int adau1977_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,