From patchwork Fri Jun 26 13:05:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Ospite X-Patchwork-Id: 6680671 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 41824C05AC for ; Fri, 26 Jun 2015 13:06:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 45375204EC for ; Fri, 26 Jun 2015 13:06:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 7F8A2204E1 for ; Fri, 26 Jun 2015 13:06:11 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id B1715264F53; Fri, 26 Jun 2015 15:06:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id C4984265055; Fri, 26 Jun 2015 15:05:55 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7112D265074; Fri, 26 Jun 2015 15:05:54 +0200 (CEST) Received: from smtp208.alice.it (smtp208.alice.it [82.57.200.104]) by alsa0.perex.cz (Postfix) with ESMTP id 3BD02264F53 for ; Fri, 26 Jun 2015 15:05:49 +0200 (CEST) Received: from jcn (82.60.124.230) by smtp208.alice.it (8.6.060.28) id 552F94A60DF838C0; Fri, 26 Jun 2015 15:05:31 +0200 Date: Fri, 26 Jun 2015 15:05:28 +0200 From: Antonio Ospite To: Vinod Koul Message-Id: <20150626150528.f9fdee3942f7e975d23dd701@ao2.it> In-Reply-To: <20150625164717.GU19530@localhost> References: <20150223183913.fb262011d6300425da7f34be@ao2.it> <20150303151621.c6fc3cfa308aed62484b87a0@ao2.it> <54F5CB3D.7020100@linux.intel.com> <20150304170218.7b397993ce670902800109f1@ao2.it> <20150403153414.b8de8df914664d7d7967120c@ao2.it> <20150414150236.3e8288307124a43941ab94f7@ao2.it> <552D1EE3.6090707@linux.intel.com> <20150624101613.GK19530@localhost> <20150625055046.GT19530@localhost> <20150625122125.72a1d72b4d3aa886d68fa3eb@ao2.it> <20150625164717.GU19530@localhost> X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) X-Face: z*RaLf`X<@C75u6Ig9}{oW$H; 1_\2t5)({*|jhM/Vb; ]yA5\I~93>J<_`<4)A{':UrE Mime-Version: 1.0 Cc: Michele Curti , alsa-devel@alsa-project.org, Mika Westerberg , Ramesh Babu K V , Omair Mohammed Abdullah , Harsha Priya , Jarkko Nikula , "Subhransu S. Prusty" Subject: Re: [alsa-devel] Intel SST on a Bay Trail tablet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 25 Jun 2015 22:17:17 +0530 Vinod Koul wrote: > On Thu, Jun 25, 2015 at 12:21:24PM +0200, Antonio Ospite wrote: > > On Thu, 25 Jun 2015 11:20:46 +0530 > > Vinod Koul wrote: > > > > > On Wed, Jun 24, 2015 at 03:46:13PM +0530, Vinod Koul wrote: > > > > On Tue, Apr 14, 2015 at 05:06:27PM +0300, Jarkko Nikula wrote: > > [...] > > > > > > > > > > Which makes me thinking how does those strings describe the SSP port > > > > > setup? E.g. do they reflect what port is actually used or could it > > > > > be possible that those are just driver strings but firmware could > > > > > have been tuned for SSP0? If I looked at earlier right, Teclast has > > > > > the low pin-count Baytrail without SSP2 but I'm not sure about that. > > > > The FW doesnt provide way to changes ports from driver in this, so this > > > > doesnt mean much. If we are sure it is not ssp2, I can provide ssp1 fw for > > > > test > > > I ahve pushed latest BYT version we have as well as added binary for second > > > SSP port. Please give it a try: > > > > > > https://git.kernel.org/cgit/linux/kernel/git/vkoul/firmware.git/commit/?h=byt&id=28ff420dd33ec299217bad7d526ff3bfd163b551 > > > > > > > Thanks Vinod, but I see these are in the ELF format, and the mainline > > driver does not support this format, at least the last time I checked it > > didn't. > My bad, updated the patch now with right format > > https://git.kernel.org/cgit/linux/kernel/git/vkoul/firmware.git/commit/?h=byt > (Adding Michele to CC) OK, so Jarkko was right: after a quick test I confirm that with fw_sst_0f28_ssp0.bin I get sound; this is quite an improvement, thanks! I am going to update the report on bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=86581 I used the amixer commands which Vinod provided in the other thread, in particular, the playback path is this one: > amixer -c0 sset 'codec_out0 mix 0 pcm0_in' on > amixer -c0 sset 'media0_out mix 0 media1_in' on The sound is a bit distorted tho, I can alleviate this effect by lowering the values of these controls: - codec_out0 Gain0 - media1_in Gain0 - pcm0_in Gain0 but the distortions do not go completely away, and they are not present in Android even at the highest volume. I will perform more tests (capture, headphones) when 4.2-rc1 is out and report back the results. JFTR, I made sure to use the DPCM driver by preventing the other one from being loaded: Would it be worth providing a SSP0 variant of fw_sst_0f28.bin-48kHz_i2s_master too? Or is the intel/atom/sst/sst_acpi.c going to completely replace intel/common/sst-acpi.c? Thanks a lot, Antonio diff --git a/sound/soc/intel/common/sst-acpi.c b/sound/soc/intel/common/sst-acpi.c index 42f293f..66ee705 100644 --- a/sound/soc/intel/common/sst-acpi.c +++ b/sound/soc/intel/common/sst-acpi.c @@ -266,7 +266,6 @@ static struct sst_acpi_desc sst_acpi_baytrail_desc = { static struct acpi_device_id sst_acpi_match[] = { { "INT33C8", (unsigned long)&sst_acpi_haswell_desc }, { "INT3438", (unsigned long)&sst_acpi_broadwell_desc }, - { "80860F28", (unsigned long)&sst_acpi_baytrail_desc }, { } }; MODULE_DEVICE_TABLE(acpi, sst_acpi_match);