From patchwork Wed Jul 8 20:17:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Ospite X-Patchwork-Id: 6750951 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E4C98C05AC for ; Wed, 8 Jul 2015 20:18:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1830320585 for ; Wed, 8 Jul 2015 20:18:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 26F022054E for ; Wed, 8 Jul 2015 20:18:03 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 06A98265A72; Wed, 8 Jul 2015 22:18:02 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id E64C9265A81; Wed, 8 Jul 2015 22:17:57 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9A016265A86; Wed, 8 Jul 2015 22:17:56 +0200 (CEST) Received: from smtp208.alice.it (smtp208.alice.it [82.57.200.104]) by alsa0.perex.cz (Postfix) with ESMTP id A9DD0265A72 for ; Wed, 8 Jul 2015 22:17:51 +0200 (CEST) Received: from jcn (82.57.81.167) by smtp208.alice.it (8.6.060.28) id 55926E4E014AE660; Wed, 8 Jul 2015 22:17:47 +0200 Date: Wed, 8 Jul 2015 22:17:45 +0200 From: Antonio Ospite To: Tyler Yeomans Message-Id: <20150708221745.f72dcbec9c96eb86ce0cbfc2@ao2.it> In-Reply-To: <559D5091.9020802@gmail.com> References: <8D3F6266AEB6384E807C6FFC6FE195E30B49AE39@BGSMSX101.gar.corp.intel.com> <20150703143608.7afb34c985d82982e929484e@ao2.it> <20150703130658.GA1689228@phare.normalesup.org> <559A90CE.2030105@gmail.com> <20150707031950.GD11002@localhost> <559BDB7F.9010105@gmail.com> <20150707170821.GL11002@localhost> <559C3F4A.5030307@gmail.com> <20150708033604.GM11002@localhost> <20150708102308.91b7258f243e354b1365a47e@ao2.it> <559D3411.6060306@gmail.com> <20150708182132.db38656fb4ccc2e38e41aba0@ao2.it> <559D5091.9020802@gmail.com> X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) X-Face: z*RaLf`X<@C75u6Ig9}{oW$H; 1_\2t5)({*|jhM/Vb; ]yA5\I~93>J<_`<4)A{':UrE Mime-Version: 1.0 Cc: Vinod Koul , "alsa-devel@alsa-project.org" , Nicolas George , "Girdwood, Liam R" , "Nikula, Jarkko" Subject: Re: [alsa-devel] Intel Baytrail Linux Audio X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 08 Jul 2015 12:32:17 -0400 Tyler Yeomans wrote: > Antonio, > > Hmm... > I have been running the driver like so: > (from sound/soc/intel/common/sst-acpi.c) > static struct sst_acpi_desc sst_acpi_baytrail_desc = { > .drv_name = "baytrail-pcm-audio", > .machines = baytrail_machines, > .resindex_lpe_base = 0, > .resindex_pcicfg_base = 1, > .resindex_fw_base = 2, > * .irqindex_host_ipc = 0,* > .sst_id = SST_DEV_ID_BYT, > .resindex_dma_base = -1, > }; > > Which is what the patch at > https://bugzilla.kernel.org/attachment.cgi?id=155341 says to do. > Ah, sorry, the info from that bug report is outdated, for the snd-intel-sst-acpi you have to change sound/soc/intel/atom/sst/sst_acpi.c: I didn't have to do that because I fixed the DSDT. > However I also noticed in this file that its looking for the wrong > firmware: > static struct sst_acpi_mach baytrail_machines[] = { > *{ "10EC5640", "byt-rt5640", "intel/fw_sst_0f28.bin-48kHz_i2s_master" },* > { "193C9890", "byt-max98090", > "intel/fw_sst_0f28.bin-48kHz_i2s_master" }, > {} > }; > > Which will not point to the SSP0 firmware uploaded by Vinod. > Just to recap: make sure to use the snd-intel-sst-acpi driver instead of snd-soc-sst-acpi as explained earlier in this thread: http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/094418.html As a quick and dirty way to do it you can remove snd-soc-sst-acpi.ko from the modules installation dir. A more robust solution would be to blacklist snd-soc-sst-acpi. Ciao, Antonio diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c index bb19b58..0badfa3 100644 --- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -118,7 +118,7 @@ static const struct sst_res_info byt_rvp_res_info = { .mbox_size = 0x1000, .acpi_lpe_res_index = 0, .acpi_ddr_index = 2, - .acpi_ipc_irq_index = 5, + .acpi_ipc_irq_index = 0, }; static struct sst_platform_info byt_rvp_platform_data = {