From patchwork Mon Sep 28 09:10:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kernel test robot X-Patchwork-Id: 7275901 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 09F0FBEEA4 for ; Mon, 28 Sep 2015 09:12:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 034DE20689 for ; Mon, 28 Sep 2015 09:12:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id C5CD320646 for ; Mon, 28 Sep 2015 09:12:12 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7EDB4261ACA; Mon, 28 Sep 2015 11:12:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 6FFC726153A; Mon, 28 Sep 2015 11:12:03 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B95C8261691; Mon, 28 Sep 2015 11:12:02 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by alsa0.perex.cz (Postfix) with ESMTP id 72D5C260688 for ; Mon, 28 Sep 2015 11:11:55 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 28 Sep 2015 02:11:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,602,1437462000"; d="scan'208";a="814550383" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by orsmga002.jf.intel.com with ESMTP; 28 Sep 2015 02:11:50 -0700 Received: from kbuild by bee with local (Exim 4.83) (envelope-from ) id 1ZgUTD-0004nD-7P; Mon, 28 Sep 2015 17:11:39 +0800 Date: Mon, 28 Sep 2015 17:10:29 +0800 From: kbuild test robot To: Songjun Wu Message-ID: <20150928091029.GA23312@roam> References: <201509281735.7lYs3Huz%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1443417278-19657-2-git-send-email-songjun.wu@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , nicolas.ferre@atmel.com, Liam Girdwood , broonie@kernel.org, kbuild-all@01.org, Songjun Wu , linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu --- atmel-classd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/atmel/atmel-classd.c +++ b/sound/soc/atmel/atmel-classd.c @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla dd->gclk = devm_clk_get(dev, "gclk"); if (IS_ERR(dd->aclk)) { - ret = PTR_ERR(dd->gclk); + ret = PTR_ERR(dd->aclk); dev_err(dev, "failed to get GCK clock: %d\n", ret); return ret; }