diff mbox

ASoC: wm8955: harmless underflow in wm8955_put_deemph()

Message ID 20151013071048.GG31537@mwanda (mailing list archive)
State Accepted
Commit 3e2a71b232d6b6270eda72ff659c31c97899c00d
Headers show

Commit Message

Dan Carpenter Oct. 13, 2015, 7:10 a.m. UTC 
Valid values for "deemph" are zero and one, but we mistakenly allow
negative values as well.  It's harmless but we may as well clean it up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Charles Keepax Oct. 13, 2015, 12:29 p.m. UTC | #1 
On Tue, Oct 13, 2015 at 10:10:48AM +0300, Dan Carpenter wrote:
> Valid values for "deemph" are zero and one, but we mistakenly allow
> negative values as well.  It's harmless but we may as well clean it up.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles
diff mbox

Patch

diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c
index 12e4435..9db00d5 100644
--- a/sound/soc/codecs/wm8955.c
+++ b/sound/soc/codecs/wm8955.c
@@ -402,7 +402,7 @@  static int wm8955_put_deemph(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
-	int deemph = ucontrol->value.integer.value[0];
+	unsigned int deemph = ucontrol->value.integer.value[0];
 
 	if (deemph > 1)
 		return -EINVAL;