| Message ID | 20151013071109.GH31537@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7ab8a54ea7914574c04c0ac441f9ab65ff21abd9 |
| Headers | show |
On Tue, Oct 13, 2015 at 10:11:09AM +0300, Dan Carpenter wrote: > Valid values for "deemph" are zero and one but we accidentally allow > negative values as well. It's harmless but it causes static checker > warnings and we may as well clean it up. Thanks for all these fixes. It almost feels like someone should volunteer to implement these deemphasis controls in some generic fashion! :)
diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c index 6a09101..969e337 100644 --- a/sound/soc/codecs/es8328.c +++ b/sound/soc/codecs/es8328.c @@ -129,7 +129,7 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol, { struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); struct es8328_priv *es8328 = snd_soc_codec_get_drvdata(codec); - int deemph = ucontrol->value.integer.value[0]; + unsigned int deemph = ucontrol->value.integer.value[0]; int ret; if (deemph > 1)
Valid values for "deemph" are zero and one but we accidentally allow negative values as well. It's harmless but it causes static checker warnings and we may as well clean it up. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>