From patchwork Thu May 12 11:01:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Keeping X-Patchwork-Id: 9083111 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 36EC59F1C1 for ; Thu, 12 May 2016 15:29:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 64A4C2024D for ; Thu, 12 May 2016 15:29:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 01E952009C for ; Thu, 12 May 2016 15:29:19 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1377E2668B2; Thu, 12 May 2016 17:29:18 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 137E82669B2; Thu, 12 May 2016 16:19:55 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 34F8D2669B2; Thu, 12 May 2016 16:19:54 +0200 (CEST) Received: from metanate.com (dougal.metanate.com [90.155.101.14]) by alsa0.perex.cz (Postfix) with ESMTP id F103A266AAF for ; Thu, 12 May 2016 13:01:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=CYC+gH+3LaD96rJ7dHmJ8CKCuM+WYbUfrZaupYw15hA=; b=HlLSbbO+Wk7g4aFLFcBRAYFwmJrPnQLJQgydq8qqI/NYOicsqH1SizIVSLIARbOM0B0erabAbyqR/JGXTF62wpIs67fgDp/2hCZ2x/b1lXpSz7cq4EX4Xcsg3yvdTDYhetBv/iZIOC+RMNyLwpu0UUZ+LCOb3NC5wNtjGSOx9Dv8UYlyApxE14Fckn1W802exTp2qKpHSP8d7n4ggSQjfGR/1WWpMY0ugK4S3SHTkCIFrE6gPefA4qeEUXAxJvzWqvk+4vIYNvKBwnQ8OkUzgpQf8SmLEJeuBfkttdDwEoU77WLtY0WFR/NzlzMXINiEeFfGrtaL11Dk3uTr8Pf0IA==; Received: from johnkeeping.plus.com ([81.174.171.191] helo=localhost.localdomain) by shrek.metanate.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.83_RC2) (envelope-from ) id 1b0oN4-0001Hc-L8; Thu, 12 May 2016 12:01:34 +0100 Date: Thu, 12 May 2016 12:01:31 +0100 From: John Keeping To: Mark Brown Message-ID: <20160512120131.30a91984.john@metanate.com> In-Reply-To: <20160510175335.GC6261@sirena.org.uk> References: <20160509112437.8924-1-john@metanate.com> <20160509112437.8924-6-john@metanate.com> <20160510175335.GC6261@sirena.org.uk> Organization: Metanate Ltd X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: es8328: Use more suitable definition for mic bias X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 10 May 2016 18:53:35 +0100, Mark Brown wrote: > On Mon, May 09, 2016 at 12:24:33PM +0100, John Keeping wrote: > > > - SND_SOC_DAPM_SUPPLY("Mic Bias", ES8328_ADCPOWER, > > - ES8328_ADCPOWER_MIC_BIAS_OFF, 1, NULL, 0), > > + SND_SOC_DAPM_MICBIAS("Mic Bias", ES8328_ADCPOWER, > > + ES8328_ADCPOWER_MIC_BIAS_OFF, 1), > > No, this is broken. The specialist MICBIAS widget is legacy and should > not be used. OK, this can be dropped. Would you consider doing something like the patch below? The only reference I can find to MICBIAS being legacy is in commit 086d7f804e26 ("ASoC: Convert WM8962 MICBIAS to a supply widget", 2011-09-23) and some following commits, there don't seem to be any comments in the documentation indicating that it's not to be used. -- >8 -- diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h index 97069466c38d..3101d53468aa 100644 --- a/include/sound/soc-dapm.h +++ b/include/sound/soc-dapm.h @@ -100,6 +100,7 @@ struct device; { .id = snd_soc_dapm_mixer_named_ctl, .name = wname, \ SND_SOC_DAPM_INIT_REG_VAL(wreg, wshift, winvert), \ .kcontrol_news = wcontrols, .num_kcontrols = wncontrols} +/* DEPRECATED: use SND_SOC_DAPM_SUPPLY */ #define SND_SOC_DAPM_MICBIAS(wname, wreg, wshift, winvert) \ { .id = snd_soc_dapm_micbias, .name = wname, \ SND_SOC_DAPM_INIT_REG_VAL(wreg, wshift, winvert), \ @@ -473,7 +474,7 @@ enum snd_soc_dapm_type { snd_soc_dapm_out_drv, /* output driver */ snd_soc_dapm_adc, /* analog to digital converter */ snd_soc_dapm_dac, /* digital to analog converter */ - snd_soc_dapm_micbias, /* microphone bias (power) */ + snd_soc_dapm_micbias, /* microphone bias (power) - DEPRECATED: use snd_soc_dapm_supply */ snd_soc_dapm_mic, /* microphone */ snd_soc_dapm_hp, /* headphones */ snd_soc_dapm_spk, /* speaker */