From patchwork Sat Jun 18 21:33:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 9185871 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 520A9601C0 for ; Sat, 18 Jun 2016 21:34:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34FFB22064 for ; Sat, 18 Jun 2016 21:34:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 24C6027C2D; Sat, 18 Jun 2016 21:34:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E15F22064 for ; Sat, 18 Jun 2016 21:34:14 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id E23BA265747; Sat, 18 Jun 2016 23:34:12 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 170AA2651D3; Sat, 18 Jun 2016 23:34:06 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id ED001265328; Sat, 18 Jun 2016 23:34:03 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by alsa0.perex.cz (Postfix) with ESMTP id 8B719261A06 for ; Sat, 18 Jun 2016 23:33:56 +0200 (CEST) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4A19E20160; Sat, 18 Jun 2016 21:33:54 +0000 (UTC) Received: from mail.kernel.org (unknown [178.162.198.111]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64E3420149; Sat, 18 Jun 2016 21:33:51 +0000 (UTC) Date: Sat, 18 Jun 2016 23:33:47 +0200 From: Sebastian Reichel To: Helen Koike Message-ID: <20160618213346.GB5510@earth> References: <20160618104038.GB31665@earth> MIME-Version: 1.0 In-Reply-To: <20160618104038.GB31665@earth> User-Agent: Mutt/1.6.0 (2016-04-01) X-Virus-Scanned: ClamAV using ClamSMTP Cc: k.kozlowski@samsung.com, lars@metafoo.de, alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, peter.ujfalusi@ti.com, broonie@kernel.org, linux-omap@vger.kernel.org, jarkko.nikula@bitmer.com Subject: Re: [alsa-devel] [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Sat, Jun 18, 2016 at 12:40:38PM +0200, Sebastian Reichel wrote: > On Sat, Jun 18, 2016 at 12:26:27AM -0300, Helen Koike wrote: > > The current tpa6130a2 driver supports only a single instance. > > This patch series add support for multiple instances by removing > > the global variable that holds the instance. This is performed by > > using the component API, regmap, the snd_soc_{info,put,get}_volsw > > API and DAPM. > > yay! *stroking cleanup of the driver from my todo list* > > > This patch series also touches code from the Nokia RX51 which I > > didn't tested (as I am testing the tpa6130a2 in another board, that > > is not upstream). I would appreciate is if someone who possesses > > the Nokia RX51 (n900) could please test the code. > > I had a look at the rx51 parts and will test later/tomorrow. Ok, here are some notes (I used the git branch you provided). First of all kernel messages contain: [ 4.217163] ALSA: Control name 'TPA6130A2 TPA6130A2 Headphone Playback Volum' truncated to 'TPA6130A2 TPA6130A2 Headphone Playback Volu' Next here is a amixer output diff: root@n900:~# amixer > amixer.old (v4.7-rc [without your patches]) root@n900:~# amixer > amixer.new root@n900:~# diff -u amixer.old amixer.new If I remember correctly, the reduced playback limit up to 42 is important on N900, since hardware can be destroyed. It may have been another control, though. Also the capture channel looks wrong. Last but not least: Audio output doesn't work, but works on a kernel without these changes. -- Sebastian --- amixer.old 2016-06-18 23:08:57.478027343 +0200 +++ amixer.new 2016-06-18 22:26:13.878102558 +0200 @@ -480,11 +480,12 @@ Capabilities: pswitch pswitch-joined Playback channels: Mono Mono: Playback [off] -Simple mixer control 'TPA6130A2 Headphone',0 - Capabilities: pvolume pvolume-joined +Simple mixer control 'TPA6130A2 TPA6130A2 Headphone Playback Volu',0 + Capabilities: volume volume-joined Playback channels: Mono - Limits: Playback 0 - 42 - Mono: Playback 0 [0%] [-59.50dB] + Capture channels: Mono + Limits: 0 - 63 + Mono: 0 [0%] Simple mixer control 'b ADC HPF Cut-off',0 Capabilities: enum Items: 'Disabled' '0.0045xFs' '0.0125xFs' '0.025xFs'