From patchwork Mon Aug 1 23:36:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 9261739 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 963D060865 for ; Wed, 3 Aug 2016 18:18:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A5C527F60 for ; Wed, 3 Aug 2016 18:18:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 76D3528249; Wed, 3 Aug 2016 18:18:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54E3F27F60 for ; Wed, 3 Aug 2016 18:18:51 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 140202665C3; Wed, 3 Aug 2016 20:18:50 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 110ED2656F3; Wed, 3 Aug 2016 14:03:05 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 67AFB265A6D; Tue, 2 Aug 2016 01:36:19 +0200 (CEST) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by alsa0.perex.cz (Postfix) with ESMTP id A3901265A01 for ; Tue, 2 Aug 2016 01:36:13 +0200 (CEST) Received: by mail-pa0-f42.google.com with SMTP id fi15so57154664pac.1 for ; Mon, 01 Aug 2016 16:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LyksRBn4jFKxsW2jcXwBSQMZoii9ehpFVgltYDbtW8s=; b=k1tQSoK8Jrus6q0YONI859YlnkFfNV4Y/9i2rMvfhd9yfcWPliEIptIhUhEFBrJcX4 eILd9yaghW280W6QvkrsOUHa6dsMOSqtld5Rm0qr0T9V/pH4WzkV/WhwSTeD5LmPGuGY t6KrVsfEpeIxqlMkL37XswDFmwsOaY5fRfp19NUXH8+kGHn0/drURz3WRv8xVR//l+rn KMVKbV0IXJ50LADhxCfdEp7zJVOf98JNaEygEyfdptpDEMeHCnEuqI3R+NfNTnnZ2kT6 NuOFdKm39aCHhU+/hXAJFXJomJNGjULcCRb67wsqYfXyb4P++kaxyp/yaHWQOeoUzV9k 0jdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LyksRBn4jFKxsW2jcXwBSQMZoii9ehpFVgltYDbtW8s=; b=PSixouywIyfhjXyrlGjQ81khYLmvmWKrNZPLwdsAQznS1ttH0fddqx2gZM46DaH230 eCeRy7AeIHiYYkAPHHGCmG7AHC7PYEz8JOIr/+sO7iDOjIb2GRDC7onkLMxFmn2XhE0r HmkQPcGidAPWmgS9/wn/rWr798UnhfNlugyVrBvg5rBv3oqM2X3woaWNd9JYDlm9bGUN Fq3VYzxRZ3NL5TOs4R+iabfbPK6sJTVlZi8klEaQKQD1/79kykq1vO9XZ3PwELTkdrqj UVFXknuttDrfKE0AXswYDkoiFzAwT4nxtVuD6sfUbLgrS53BNu0WNPrkqehAbrPICCUt eepw== X-Gm-Message-State: AEkooutn2Y+b4SmDSuzvxm6YTiPa3pRO+Tqx0fU8nh1LkgZO4uZqu0/3KwwJkKLx5IlXimE3 X-Received: by 10.67.13.196 with SMTP id fa4mr102140413pad.115.1470094571919; Mon, 01 Aug 2016 16:36:11 -0700 (PDT) Received: from localhost (c-98-203-232-209.hsd1.wa.comcast.net. [98.203.232.209]) by smtp.gmail.com with ESMTPSA id u1sm48225983pfu.12.2016.08.01.16.36.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 16:36:11 -0700 (PDT) From: Kevin Hilman To: Liam Girdwood , Mark Brown Date: Mon, 1 Aug 2016 16:36:08 -0700 Message-Id: <20160801233610.10479-1-khilman@baylibre.com> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 03 Aug 2016 14:03:03 +0200 Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , Sekhar Nori , open list , Takashi Iwai Subject: [alsa-devel] [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP An ASoC driver using simple-card, when built as a module gets the following error at module load time: [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) fix this by including simple-card-utils.o symbols in the module build its symols are resolved correctly. Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp, with all of ASoC built as modules. Cc: Sekhar Nori Signed-off-by: Kevin Hilman Tested-by: Sekhar Nori --- sound/soc/generic/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/generic/Makefile b/sound/soc/generic/Makefile index 45602ca8536e..ff0c55eee4f7 100644 --- a/sound/soc/generic/Makefile +++ b/sound/soc/generic/Makefile @@ -2,4 +2,8 @@ obj-$(CONFIG_SND_SIMPLE_CARD_UTILS) := simple-card-utils.o snd-soc-simple-card-objs := simple-card.o +ifneq ($(CONFIG_SND_SIMPLE_CARD_UTILS),) +snd-soc-simple-card-objs += simple-card-utils.o +endif + obj-$(CONFIG_SND_SIMPLE_CARD) += snd-soc-simple-card.o