From patchwork Tue Aug 2 12:28:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9261961 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CD5F66048F for ; Wed, 3 Aug 2016 18:56:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C02B1280DE for ; Wed, 3 Aug 2016 18:56:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B47B628249; Wed, 3 Aug 2016 18:56:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5364280DE for ; Wed, 3 Aug 2016 18:56:17 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5F31026803B; Wed, 3 Aug 2016 20:56:16 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 2D1112686C2; Wed, 3 Aug 2016 14:03:56 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B25872669CA; Tue, 2 Aug 2016 18:20:54 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by alsa0.perex.cz (Postfix) with ESMTP id A6983266E94 for ; Tue, 2 Aug 2016 15:06:01 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 02 Aug 2016 06:06:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.28,460,1464678000"; d="scan'208"; a="1033615364" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by fmsmga002.fm.intel.com with ESMTP; 02 Aug 2016 06:05:58 -0700 From: Baole Ni To: perex@perex.cz, tiwai@suse.com, serge@hallyn.com, davem@davemloft.net, kadlec@blackhole.kfki.hu, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Date: Tue, 2 Aug 2016 20:28:20 +0800 Message-Id: <20160802122820.31753-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 X-Mailman-Approved-At: Wed, 03 Aug 2016 14:03:02 +0200 Cc: baolex.ni@intel.com, aryabinin@virtuozzo.com, alsa-devel@alsa-project.org, chuansheng.liu@intel.com, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 1223/1285] Replace numeric parameter like 0444 with macro X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- sound/pci/emu10k1/emu10k1.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sound/pci/emu10k1/emu10k1.c b/sound/pci/emu10k1/emu10k1.c index db7a2e5..6440655 100644 --- a/sound/pci/emu10k1/emu10k1.c +++ b/sound/pci/emu10k1/emu10k1.c @@ -54,27 +54,27 @@ static bool enable_ir[SNDRV_CARDS]; static uint subsystem[SNDRV_CARDS]; /* Force card subsystem model */ static uint delay_pcm_irq[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 2}; -module_param_array(index, int, NULL, 0444); +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for the EMU10K1 soundcard."); -module_param_array(id, charp, NULL, 0444); +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string for the EMU10K1 soundcard."); -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable, "Enable the EMU10K1 soundcard."); -module_param_array(extin, int, NULL, 0444); +module_param_array(extin, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(extin, "Available external inputs for FX8010. Zero=default."); -module_param_array(extout, int, NULL, 0444); +module_param_array(extout, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(extout, "Available external outputs for FX8010. Zero=default."); -module_param_array(seq_ports, int, NULL, 0444); +module_param_array(seq_ports, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(seq_ports, "Allocated sequencer ports for internal synthesizer."); -module_param_array(max_synth_voices, int, NULL, 0444); +module_param_array(max_synth_voices, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_synth_voices, "Maximum number of voices for WaveTable."); -module_param_array(max_buffer_size, int, NULL, 0444); +module_param_array(max_buffer_size, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_buffer_size, "Maximum sample buffer size in MB."); -module_param_array(enable_ir, bool, NULL, 0444); +module_param_array(enable_ir, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable_ir, "Enable IR."); -module_param_array(subsystem, uint, NULL, 0444); +module_param_array(subsystem, uint, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(subsystem, "Force card subsystem model."); -module_param_array(delay_pcm_irq, uint, NULL, 0444); +module_param_array(delay_pcm_irq, uint, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(delay_pcm_irq, "Delay PCM interrupt by specified number of samples (default 0)."); /* * Class 0401: 1102:0008 (rev 00) Subsystem: 1102:1001 -> Audigy2 Value Model:SB0400