From patchwork Tue Aug 2 12:28:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9261973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3C1DF6048F for ; Wed, 3 Aug 2016 18:58:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FB0A27FAC for ; Wed, 3 Aug 2016 18:58:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2406F28236; Wed, 3 Aug 2016 18:58:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C2BA27FAC for ; Wed, 3 Aug 2016 18:58:47 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 45174267DF4; Wed, 3 Aug 2016 20:58:46 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 011F02686EB; Wed, 3 Aug 2016 14:03:59 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9FD812669E3; Tue, 2 Aug 2016 18:21:05 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by alsa0.perex.cz (Postfix) with ESMTP id 34D8E266E9C for ; Tue, 2 Aug 2016 15:06:23 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 02 Aug 2016 06:06:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.28,460,1464678000"; d="scan'208"; a="1028298704" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2016 06:06:16 -0700 From: Baole Ni To: perex@perex.cz, tiwai@suse.com, serge@hallyn.com, davem@davemloft.net, kadlec@blackhole.kfki.hu, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Date: Tue, 2 Aug 2016 20:28:37 +0800 Message-Id: <20160802122838.31957-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 X-Mailman-Approved-At: Wed, 03 Aug 2016 14:03:02 +0200 Cc: baolex.ni@intel.com, aryabinin@virtuozzo.com, alsa-devel@alsa-project.org, chuansheng.liu@intel.com, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 1226/1285] Replace numeric parameter like 0444 with macro X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- sound/pci/ens1370.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c index 626cd21..4116d6f 100644 --- a/sound/pci/ens1370.c +++ b/sound/pci/ens1370.c @@ -98,25 +98,25 @@ static int spdif[SNDRV_CARDS]; static int lineio[SNDRV_CARDS]; #endif -module_param_array(index, int, NULL, 0444); +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for Ensoniq AudioPCI soundcard."); -module_param_array(id, charp, NULL, 0444); +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string for Ensoniq AudioPCI soundcard."); -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable, "Enable Ensoniq AudioPCI soundcard."); #ifdef SUPPORT_JOYSTICK #ifdef CHIP1371 -module_param_array(joystick_port, int, NULL, 0444); +module_param_array(joystick_port, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(joystick_port, "Joystick port address."); #else -module_param_array(joystick, bool, NULL, 0444); +module_param_array(joystick, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(joystick, "Enable joystick."); #endif #endif /* SUPPORT_JOYSTICK */ #ifdef CHIP1371 -module_param_array(spdif, int, NULL, 0444); +module_param_array(spdif, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(spdif, "S/PDIF output (-1 = none, 0 = auto, 1 = force)."); -module_param_array(lineio, int, NULL, 0444); +module_param_array(lineio, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(lineio, "Line In to Rear Out (0 = auto, 1 = force)."); #endif