From patchwork Tue Aug 2 12:30:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9262025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7D4A96048F for ; Wed, 3 Aug 2016 19:05:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7035827FA9 for ; Wed, 3 Aug 2016 19:05:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 64CC52823D; Wed, 3 Aug 2016 19:05:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EE1D27FA9 for ; Wed, 3 Aug 2016 19:05:56 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id AA9062683CE; Wed, 3 Aug 2016 21:05:55 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1003226876E; Wed, 3 Aug 2016 14:04:08 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4F8C5266A02; Tue, 2 Aug 2016 18:21:27 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by alsa0.perex.cz (Postfix) with ESMTP id 67F9A266EA9 for ; Tue, 2 Aug 2016 15:08:15 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 02 Aug 2016 06:08:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.28,460,1464678000"; d="scan'208"; a="1033616790" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by fmsmga002.fm.intel.com with ESMTP; 02 Aug 2016 06:08:12 -0700 From: Baole Ni To: perex@perex.cz, tiwai@suse.com, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, kadlec@blackhole.kfki.hu, davem@davemloft.net, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Date: Tue, 2 Aug 2016 20:30:34 +0800 Message-Id: <20160802123034.721-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 X-Mailman-Approved-At: Wed, 03 Aug 2016 14:03:02 +0200 Cc: baolex.ni@intel.com, aryabinin@virtuozzo.com, alsa-devel@alsa-project.org, chuansheng.liu@intel.com, linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 1243/1285] Replace numeric parameter like 0444 with macro X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- sound/pci/nm256/nm256.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c index 4735e27..6235b1e 100644 --- a/sound/pci/nm256/nm256.c +++ b/sound/pci/nm256/nm256.c @@ -64,30 +64,30 @@ static bool vaio_hack; /* disabled */ static bool reset_workaround; static bool reset_workaround_2; -module_param(index, int, 0444); +module_param(index, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for " CARD_NAME " soundcard."); -module_param(id, charp, 0444); +module_param(id, charp, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string for " CARD_NAME " soundcard."); -module_param(playback_bufsize, int, 0444); +module_param(playback_bufsize, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(playback_bufsize, "DAC frame size in kB for " CARD_NAME " soundcard."); -module_param(capture_bufsize, int, 0444); +module_param(capture_bufsize, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(capture_bufsize, "ADC frame size in kB for " CARD_NAME " soundcard."); -module_param(force_ac97, bool, 0444); +module_param(force_ac97, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(force_ac97, "Force to use AC97 codec for " CARD_NAME " soundcard."); -module_param(buffer_top, int, 0444); +module_param(buffer_top, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(buffer_top, "Set the top address of audio buffer for " CARD_NAME " soundcard."); -module_param(use_cache, bool, 0444); +module_param(use_cache, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(use_cache, "Enable the cache for coefficient table access."); -module_param(vaio_hack, bool, 0444); +module_param(vaio_hack, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(vaio_hack, "Enable workaround for Sony VAIO notebooks."); -module_param(reset_workaround, bool, 0444); +module_param(reset_workaround, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(reset_workaround, "Enable AC97 RESET workaround for some laptops."); -module_param(reset_workaround_2, bool, 0444); +module_param(reset_workaround_2, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(reset_workaround_2, "Enable extended AC97 RESET workaround for some other laptops."); /* just for backward compatibility */ static bool enable; -module_param(enable, bool, 0444); +module_param(enable, bool, S_IRUSR | S_IRGRP | S_IROTH);