From patchwork Mon Sep 19 19:30:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 9340465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DF0B16022E for ; Mon, 19 Sep 2016 20:31:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2E3129885 for ; Mon, 19 Sep 2016 20:31:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C729629889; Mon, 19 Sep 2016 20:31:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6AA7329885 for ; Mon, 19 Sep 2016 20:31:49 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id DCE7F266C3E; Mon, 19 Sep 2016 22:31:47 +0200 (CEST) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id CD8DA266619; Mon, 19 Sep 2016 22:29:29 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 6349C266569; Mon, 19 Sep 2016 21:30:48 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by alsa0.perex.cz (Postfix) with ESMTP id 193C8266666 for ; Mon, 19 Sep 2016 21:30:45 +0200 (CEST) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3sdGFd5lfwz3hk70; Mon, 19 Sep 2016 21:30:45 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3sdGFd5TRdzvkpy; Mon, 19 Sep 2016 21:30:45 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id CaucSa96ZWxf; Mon, 19 Sep 2016 21:30:44 +0200 (CEST) X-Auth-Info: +57Wf8cEeEw7Ef/bOt2tOziPVv5yWEVcEWY5Gt9Zimo= Received: from chi.lan (unknown [195.140.253.167]) by mail.mnet-online.de (Postfix) with ESMTPA; Mon, 19 Sep 2016 21:30:44 +0200 (CEST) From: Marek Vasut To: alsa-devel@alsa-project.org Date: Mon, 19 Sep 2016 21:30:28 +0200 Message-Id: <20160919193029.8119-4-marex@denx.de> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20160919193029.8119-1-marex@denx.de> References: <20160919193029.8119-1-marex@denx.de> Cc: Marek Vasut , Xiubo Li , Liam Girdwood , Timur Tabi , Nicolin Chen , Mark Brown , Fabio Estevam Subject: [alsa-devel] [PATCH 4/5] ASoC: fsl_ssi: use flat regmap cache X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Same as commit ce492b3b8f99cf9d2f807ec22d8805c996a09503 Subject: drm/fsl-dcu: use flat regmap cache Using flat regmap cache instead of RB-tree to avoid the following lockdep warning on driver load: WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2871 lockdep_trace_alloc+0x104/0x128 DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) The RB-tree regmap cache needs to allocate new space on first writes. However, allocations in an atomic context (e.g. when a spinlock is held) are not allowed. The function regmap_write calls map->lock, which acquires a spinlock in the fast_io case. Since the driver uses MMIO, the regmap bus of type regmap_mmio is being used which has fast_io set to true. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Liam Girdwood Cc: Mark Brown Cc: Nicolin Chen Cc: Timur Tabi Cc: Xiubo Li --- sound/soc/fsl/fsl_ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index bedec4a..5034943 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -182,7 +182,7 @@ static const struct regmap_config fsl_ssi_regconfig = { .volatile_reg = fsl_ssi_volatile_reg, .precious_reg = fsl_ssi_precious_reg, .writeable_reg = fsl_ssi_writeable_reg, - .cache_type = REGCACHE_RBTREE, + .cache_type = REGCACHE_FLAT, }; struct fsl_ssi_soc_data {