| Message ID | 20161028143250.10711-1-sebastien.guiriec@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6a7f5e41128de638fae7522262d18a6ef9cf1096 |
| Headers | show |
On Fri, Oct 28, 2016 at 04:32:50PM +0200, Sebastien Guiriec wrote: > + dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n", > + init->fw_version.type, init->fw_version.major, > + init->fw_version.minor, init->fw_version.build); > + dev_dbg(sst_drv_ctx->dev, "Build date %s Time %s\n", > + init->build_info.date, init->build_info.time); Seems like an odd mix of info/dbg but whatever. I'd also recommend adding sysfs or at least debugfs files exposing this information, that way you can still get at it even if the kernel log has been filled with other things.
On 28/10/2016 18:33, Mark Brown wrote: > On Fri, Oct 28, 2016 at 04:32:50PM +0200, Sebastien Guiriec wrote: > >> + dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n", >> + init->fw_version.type, init->fw_version.major, >> + init->fw_version.minor, init->fw_version.build); >> + dev_dbg(sst_drv_ctx->dev, "Build date %s Time %s\n", >> + init->build_info.date, init->build_info.time); > > Seems like an odd mix of info/dbg but whatever. I'd also recommend > adding sysfs or at least debugfs files exposing this information, that > way you can still get at it even if the kernel log has been filled with > other things. Thansk Mark. I will remove the build time and date as the most important info is the FW version in order to have traceability of the different FW. I will add sysfs entry also. Sebastien --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c index 8afa6fe..8cbbdcf 100644 --- a/sound/soc/intel/atom/sst/sst_ipc.c +++ b/sound/soc/intel/atom/sst/sst_ipc.c @@ -236,6 +236,11 @@ static void process_fw_init(struct intel_sst_drv *sst_drv_ctx, retval = init->result; goto ret; } + dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n", + init->fw_version.type, init->fw_version.major, + init->fw_version.minor, init->fw_version.build); + dev_dbg(sst_drv_ctx->dev, "Build date %s Time %s\n", + init->build_info.date, init->build_info.time); ret: sst_wake_up_block(sst_drv_ctx, retval, FW_DWNL_ID, 0 , NULL, 0);
This patch is adding debug information related to SST FW version. Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com> --- sound/soc/intel/atom/sst/sst_ipc.c | 5 +++++ 1 file changed, 5 insertions(+)