| Message ID | 20161117110046.GC32143@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > - pr_debug("PCM data: addr 0x%08ulx len %d\n", > + pr_debug("PCM data: addr 0x%08lx len %d\n", > (u32)runtime->dma_addr, runtime->dma_bytes); While there, why not using %pad as suggested by Documentation/printk-formats.txt? Regards, Bojan
On Thu, Nov 17, 2016 at 02:31:06PM +0100, bojan prtvar wrote: > Hi, > > On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter > <dan.carpenter@oracle.com> wrote: > > > - pr_debug("PCM data: addr 0x%08ulx len %d\n", > > + pr_debug("PCM data: addr 0x%08lx len %d\n", > > (u32)runtime->dma_addr, runtime->dma_bytes); > > While there, why not using %pad as suggested by > Documentation/printk-formats.txt? Oh crap. I never even compiled this stuff... I'm really sorry it's been a while since I screwed up like this. Sorry about this. That sounds like a good idea but I don't have a cross compiler set up so I'm going to leave it alone for now. regards, dan carpenter
diff --git a/sound/soc/sh/dma-sh7760.c b/sound/soc/sh/dma-sh7760.c index 8fad444..c28ee1a 100644 --- a/sound/soc/sh/dma-sh7760.c +++ b/sound/soc/sh/dma-sh7760.c @@ -204,7 +204,7 @@ static int camelot_prepare(struct snd_pcm_substream *substream) struct snd_soc_pcm_runtime *rtd = substream->private_data; struct camelot_pcm *cam = &cam_pcm_data[rtd->cpu_dai->id]; - pr_debug("PCM data: addr 0x%08ulx len %d\n", + pr_debug("PCM data: addr 0x%08lx len %d\n", (u32)runtime->dma_addr, runtime->dma_bytes); if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
We intended to print a hex here, but the code will print a base 10 with an x on the end. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>