diff mbox

ASoC: sunxi: Uninitialized variable in probe()

Message ID 20161123222906.GA27895@mwanda (mailing list archive)
State Accepted
Commit 999982ef7c7f8aa131d32ef551897804443a40a1
Headers show

Commit Message

Dan Carpenter Nov. 23, 2016, 10:29 p.m. UTC 
Oddly enough, my version of GCC misses this uninitialized variable.

Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Chen-Yu Tsai Nov. 24, 2016, 4:33 a.m. UTC | #1 
On Thu, Nov 24, 2016 at 6:29 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Oddly enough, my version of GCC misses this uninitialized variable.
>
> Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>
Maxime Ripard Nov. 24, 2016, 10:29 a.m. UTC | #2 
On Thu, Nov 24, 2016 at 01:29:06AM +0300, Dan Carpenter wrote:
> Oddly enough, my version of GCC misses this uninitialized variable.
> 
> Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime
diff mbox

Patch

diff --git a/sound/soc/sunxi/sun8i-codec-analog.c b/sound/soc/sunxi/sun8i-codec-analog.c
index 222bbd4..af02290 100644
--- a/sound/soc/sunxi/sun8i-codec-analog.c
+++ b/sound/soc/sunxi/sun8i-codec-analog.c
@@ -589,7 +589,7 @@  static int sun8i_codec_analog_cmpnt_probe(struct snd_soc_component *cmpnt)
 	}
 
 	if (quirks->has_hmic) {
-		sun8i_codec_add_hmic(cmpnt);
+		ret = sun8i_codec_add_hmic(cmpnt);
 		if (ret)
 			return ret;
 	}