From patchwork Thu Dec 8 12:36:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9467847 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DE09060231 for ; Fri, 9 Dec 2016 10:48:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D06CF2022B for ; Fri, 9 Dec 2016 10:48:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C0EB2285C8; Fri, 9 Dec 2016 10:48:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E589F2022B for ; Fri, 9 Dec 2016 10:48:50 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 23B8F26775B; Fri, 9 Dec 2016 11:48:47 +0100 (CET) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id E2B9B267753; Fri, 9 Dec 2016 11:46:25 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5C20C267459; Thu, 8 Dec 2016 13:37:11 +0100 (CET) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by alsa0.perex.cz (Postfix) with ESMTP id 3B0F32668F6 for ; Thu, 8 Dec 2016 13:37:06 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id g23so3327455wme.1 for ; Thu, 08 Dec 2016 04:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L1qMQNf//chRfslvsS4IWcl33xoxtDQFu0HBGJktO0U=; b=tt1JmoQnxJvo1RpSCGN62HIFtFe2Tqt3m5p0zoxp0j0Am2nePACZLikHHEmuPn8Gr3 WVzI+zcPWU8z4ibFjrsEdvUVpKrPM3NvACzdZ7CXwAmuyKGbLTIjL7VQJtT7uaXYomYj MABsrlgddZxh9PtSYsfNX6Ymmw1TlroPJqwUI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L1qMQNf//chRfslvsS4IWcl33xoxtDQFu0HBGJktO0U=; b=bQFyCdi+hwsCIwqRin5JrqDTuYyi85nuMhgnmHmWexvPuOlxST5x6xCkZW8FbC2tKT 40QaOtiAzQOw3RjV47Fk7av+2QwO/+KSLCGlN44sr0m6TWL506NjJF5+u34XWhRF9gEx WqYF1h8Utcmp9vcav5bmY7AEElj39UDIvYspRtVikrir1foDHNqI+jfPrCYtgx4B2FBc nYXPHMmRu5zudfFnLOgUAMSiITJNtc7xNXxoWJZ61comglgAaCseAMhjKHf+GoSClTs+ y1wtH8cIXZCwfqjKGhYrH+sQ6rKNrS/40cZ7RKrSWKnRC1Ak8BCy9OR+8I0z2Z0pIPOK 5oAg== X-Gm-Message-State: AKaTC020h3aRAc2ScEuqJUxRQlrBo+rMfBYoa2GnQRJo6jTgYz/OsRaN+wtTwmL9yAoFhw== X-Received: by 10.28.225.11 with SMTP id y11mr1939237wmg.93.1481200626676; Thu, 08 Dec 2016 04:37:06 -0800 (PST) Received: from kmp-mobile.hq.kempniu.pl (kmp-mobile.hq.kempniu.pl. [2001:6a0:200:83b0::2d90]) by smtp.googlemail.com with ESMTPSA id a13sm15095293wma.18.2016.12.08.04.37.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Dec 2016 04:37:06 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Richard Purdie , Jacek Anaszewski , Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Darren Hart , Jaroslav Kysela , Takashi Iwai Date: Thu, 8 Dec 2016 13:36:12 +0100 Message-Id: <20161208123618.28603-2-kernel@kempniu.pl> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161208123618.28603-1-kernel@kempniu.pl> References: <20161208123618.28603-1-kernel@kempniu.pl> MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 09 Dec 2016 10:19:32 +0100 Cc: alsa-devel@alsa-project.org, Louis Davis , linux-kernel@vger.kernel.org, Bob Rodgers , platform-driver-x86@vger.kernel.org, Hui Wang , Alex Hung , Jim Dailey , linux-leds@vger.kernel.org Subject: [alsa-devel] [PATCH 1/7] dell-led: remove GUID check from dell_micmute_led_set() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP As dell_micmute_led_set() no longer uses the dell_wmi_perform_query() method, which was removed in 0c41a08 ("dell-led: use dell_smbios_send_request() for performing SMBIOS calls"), the DELL_APP_GUID check is redundant and thus can be safely removed. Signed-off-by: Michał Kępień Reviewed-by: Pali Rohár --- drivers/leds/dell-led.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c index b3d6e9c..e8e8f67 100644 --- a/drivers/leds/dell-led.c +++ b/drivers/leds/dell-led.c @@ -51,9 +51,6 @@ static int dell_micmute_led_set(int state) struct calling_interface_buffer *buffer; struct calling_interface_token *token; - if (!wmi_has_guid(DELL_APP_GUID)) - return -ENODEV; - if (state == 0) token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE); else if (state == 1)