From patchwork Fri Dec 9 13:02:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Ospite X-Patchwork-Id: 9468647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6224F607D8 for ; Fri, 9 Dec 2016 16:23:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54D652864D for ; Fri, 9 Dec 2016 16:23:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4999F28653; Fri, 9 Dec 2016 16:23:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 42BFA2864D for ; Fri, 9 Dec 2016 16:23:07 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 108AE267825; Fri, 9 Dec 2016 17:23:06 +0100 (CET) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id BDF0D2677F0; Fri, 9 Dec 2016 17:20:42 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 40D8D2677A7; Fri, 9 Dec 2016 14:03:06 +0100 (CET) Received: from smtp205.alice.it (smtp205.alice.it [82.57.200.101]) by alsa0.perex.cz (Postfix) with ESMTP id 8F1102677AE for ; Fri, 9 Dec 2016 14:02:59 +0100 (CET) Received: from jcn (79.56.137.99) by smtp205.alice.it (8.6.060.28) id 583FFC5E029AEDC5; Fri, 9 Dec 2016 14:02:52 +0100 Received: from ao2 by jcn with local (Exim 4.88) (envelope-from ) id 1cFKp8-00054e-HB; Fri, 09 Dec 2016 14:02:50 +0100 From: Antonio Ospite To: alsa-devel@alsa-project.org Date: Fri, 9 Dec 2016 14:02:29 +0100 Message-Id: <20161209130232.19457-3-ao2@ao2.it> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20161209130232.19457-1-ao2@ao2.it> References: <20161209130232.19457-1-ao2@ao2.it> Cc: Takashi Iwai , Liam Girdwood , Antonio Ospite Subject: [alsa-devel] [alsa-utils][PATCH 2/5] configure.ac: fix the check for xmlto availability X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The same $xmlto variable is used both in AC_ARG_ENABLE and AC_CHECK_PROG, but the latter is not setting a value to it when the program is not found. These two facts result in the "yes" value from the AC_ARG_ENABLE macro to be still kept in the variable when the program is not found by AC_CHECK_PROG, causing USE_XMLTO to be always set, finally resulting in a build failure in case the xmlto program is not actually in the PATH. As possible fix could have been to set "no" as a value in AC_CHECK_PROG when program is not found. However using two separate variables is more explicit, so fix the issue this way. Signed-off-by: Antonio Ospite --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 2221617..c9629bb 100644 --- a/configure.ac +++ b/configure.ac @@ -166,14 +166,14 @@ AC_ARG_ENABLE(alsaloop, esac],[alsaloop=true]) AM_CONDITIONAL(ALSALOOP, test x$alsaloop = xtrue) -xmlto="" +xmlto_available="" AC_ARG_ENABLE(xmlto, AS_HELP_STRING([--disable-xmlto], [Disable man page creation via xmlto]), xmlto="$enableval", xmlto="yes") if test "$xmlto" = "yes"; then - AC_CHECK_PROG([xmlto], [xmlto], [yes]) + AC_CHECK_PROG([xmlto_available], [xmlto], [yes]) fi -AM_CONDITIONAL(USE_XMLTO, test x"$xmlto" = xyes) +AM_CONDITIONAL(USE_XMLTO, test x"$xmlto_available" = xyes) AC_ARG_WITH( [udev-rules-dir],