From patchwork Fri Feb 17 07:57:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9579065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1BFB3600C5 for ; Fri, 17 Feb 2017 08:05:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09996286AB for ; Fri, 17 Feb 2017 08:05:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F0138286B2; Fri, 17 Feb 2017 08:05:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 47F66286AB for ; Fri, 17 Feb 2017 08:05:39 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id AC7AD26711B; Fri, 17 Feb 2017 08:58:10 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 094AF266C35; Fri, 17 Feb 2017 08:58:05 +0100 (CET) Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) by alsa0.perex.cz (Postfix) with ESMTP id A446A266C27 for ; Fri, 17 Feb 2017 08:58:03 +0100 (CET) Received: by mail-lf0-f67.google.com with SMTP id x1so3194449lff.0 for ; Thu, 16 Feb 2017 23:58:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GxTfth66a0trkxgaq+W4VyclQnoCQhchqNrGFI95cXo=; b=U75bouLL/HSQASrqjN9Xl+izZ6uPDNlR8YHOw0vYN91m/+UD4aQr9cwNAvjTlyY/lM QnnVcQfkQmQbPsnItmFYJXr7+OKrVk0lovkSXCSj109IDv0dSs6y2wa1smHjK7TihzyP JAe/ISAlEyLltMBljWkzeH2S+zXmpd+VJ3NJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GxTfth66a0trkxgaq+W4VyclQnoCQhchqNrGFI95cXo=; b=l7OCqlkw24OEmn1tWP80XA//394iOAYdbGE7u8pbbrRlGT+bDHV/SFy2FSsBAE9J9O TdPQMMM21Fg16UBccJWskIjtKU/p+LFp/pF8uI2TkJfMNa0KSdCfLdORn+r5VwPJzI9L CXuwRZgrGwmU4IyLxFs9cGq6aayfaK01wpWE5x+c2xVyyVCY2/YUflpJgPx6Whk0NHaK S4xztBZcn/ODfY9gs8q97wAdKVm/wmI3rcCjUcTjMaGtV34gokwzKUqJorj+2d/mH877 0OxI7662gRjdt+eg6V4isICydRdJV/Vj3Qck7WMNKyqseQx4JyueT6b2q763SZmH0Omb DLIA== X-Gm-Message-State: AMke39l4Mch9Fa+IR/1MDwR40emkuULWa3s7txu4lBE38uIPgrC8e3dg4cJAglC6D7MsBA== X-Received: by 10.25.19.67 with SMTP id j64mr1898580lfi.34.1487318283103; Thu, 16 Feb 2017 23:58:03 -0800 (PST) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id 206sm2336457ljf.35.2017.02.16.23.58.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 23:58:02 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Richard Purdie , Jacek Anaszewski , Pavel Machek , Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Darren Hart , Andy Shevchenko , Jaroslav Kysela , Takashi Iwai Date: Fri, 17 Feb 2017 08:57:47 +0100 Message-Id: <20170217075753.12702-2-kernel@kempniu.pl> X-Mailer: git-send-email 2.11.1 In-Reply-To: <20170217075753.12702-1-kernel@kempniu.pl> References: <20170217075753.12702-1-kernel@kempniu.pl> MIME-Version: 1.0 Cc: linux-kernel@vger.kernel.org, Alex Hung , alsa-devel@alsa-project.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [alsa-devel] [PATCH v3 1/7] dell-led: remove GUID check from dell_micmute_led_set() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP As dell_micmute_led_set() no longer uses the dell_wmi_perform_query() method, which was removed in commit 0c41a08e131d ("dell-led: use dell_smbios_send_request() for performing SMBIOS calls"), the DELL_APP_GUID check is redundant and thus can be safely removed. Signed-off-by: Michał Kępień Tested-by: Alex Hung Reviewed-by: Pali Rohár --- drivers/leds/dell-led.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c index b3d6e9c15cf9..e8e8f67224c1 100644 --- a/drivers/leds/dell-led.c +++ b/drivers/leds/dell-led.c @@ -51,9 +51,6 @@ static int dell_micmute_led_set(int state) struct calling_interface_buffer *buffer; struct calling_interface_token *token; - if (!wmi_has_guid(DELL_APP_GUID)) - return -ENODEV; - if (state == 0) token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE); else if (state == 1)