From patchwork Mon Feb 20 20:58:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9588357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4B3496057F for ; Thu, 23 Feb 2017 14:21:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3ACA326785 for ; Thu, 23 Feb 2017 14:21:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2FB082875A; Thu, 23 Feb 2017 14:21:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE7EF28758 for ; Thu, 23 Feb 2017 14:21:05 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id CC6622666EA; Thu, 23 Feb 2017 15:09:13 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 8018D266BDE; Mon, 20 Feb 2017 21:59:14 +0100 (CET) Received: from pokefinder.org (unknown [89.238.76.85]) by alsa0.perex.cz (Postfix) with ESMTP id C29DB266B26 for ; Mon, 20 Feb 2017 21:59:10 +0100 (CET) Received: from localhost (p54B33C89.dip0.t-ipconnect.de [84.179.60.137]) by pokefinder.org (Postfix) with ESMTPSA id 25AAD31C0A5; Mon, 20 Feb 2017 21:59:09 +0100 (CET) From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Date: Mon, 20 Feb 2017 21:58:34 +0100 Message-Id: <20170220205858.10799-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 X-Mailman-Approved-At: Thu, 23 Feb 2017 15:09:07 +0100 Cc: Wolfram Sang , alsa-devel@alsa-project.org, Mark Brown , Kuninori Morimoto , Liam Girdwood Subject: [alsa-devel] [PATCH] ASoC: rsnd: drop useles self-assignments X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Coverity reported (CID 1397992) this self-assignment. I think the code stays readable even with the assignments removed. Signed-off-by: Wolfram Sang --- sound/soc/sh/rcar/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 47b370cb2d3b3a..24adb3cc17aa63 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -674,12 +674,10 @@ static int rsnd_soc_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) /* set clock inversion */ switch (fmt & SND_SOC_DAIFMT_INV_MASK) { case SND_SOC_DAIFMT_NB_IF: - rdai->bit_clk_inv = rdai->bit_clk_inv; rdai->frm_clk_inv = !rdai->frm_clk_inv; break; case SND_SOC_DAIFMT_IB_NF: rdai->bit_clk_inv = !rdai->bit_clk_inv; - rdai->frm_clk_inv = rdai->frm_clk_inv; break; case SND_SOC_DAIFMT_IB_IF: rdai->bit_clk_inv = !rdai->bit_clk_inv;