| Message ID | 20170221220255.242105-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 21 Feb 2017 23:02:37 +0100, Arnd Bergmann wrote: > > The newly added driver uses the PCM helpers and fails to link if they are disabled: > > sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend': > intel_hdmi_audio.c:(.text+0x15906): undefined reference to `snd_pcm_suspend' > sound/built-in.o: In function `had_pcm_hw_params': > intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to `snd_pcm_lib_malloc_pages' > sound/built-in.o: In function `had_pcm_open': > intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer' > > This uses a Kconfig 'select' statement to make sure they are enabled. > > Fixes: 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks, applied. Takashi
diff --git a/sound/x86/Kconfig b/sound/x86/Kconfig index 30d066e4885e..84c8f8fc597c 100644 --- a/sound/x86/Kconfig +++ b/sound/x86/Kconfig @@ -9,6 +9,7 @@ if SND_X86 config HDMI_LPE_AUDIO tristate "HDMI audio without HDaudio on Intel Atom platforms" depends on DRM_I915 + select SND_PCM help Choose this option to support HDMI LPE Audio mode
The newly added driver uses the PCM helpers and fails to link if they are disabled: sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend': intel_hdmi_audio.c:(.text+0x15906): undefined reference to `snd_pcm_suspend' sound/built-in.o: In function `had_pcm_hw_params': intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to `snd_pcm_lib_malloc_pages' sound/built-in.o: In function `had_pcm_open': intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer' This uses a Kconfig 'select' statement to make sure they are enabled. Fixes: 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- sound/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)