| Message ID | 20170417150408.20935-2-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | beb5989a8c6c6867b4e873cca2a66d31f977368f |
| Headers | show |
L'octidi 28 germinal, an CCXXV, Pierre-Louis Bossart a écrit : > There are multiple skews of the same Lenovo audio hardware > based on the Realtek RT5670 codec. > Manufacturer: LENOVO > Product Name: 20359 > Version: Lenovo Miix 2 10 Interesting. Any chance that applies to the Miix 3-1030 too? > + { > + .callback = byt_thinkpad10_quirk_cb, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), I guess I should run dmidecode, get the kernel sources, make a similar change and test. Unfortunately, I will probably not have time to do that until at least the week-end. Thanks.
On 04/17/2017 10:12 AM, Nicolas George wrote: > L'octidi 28 germinal, an CCXXV, Pierre-Louis Bossart a écrit : >> There are multiple skews of the same Lenovo audio hardware >> based on the Realtek RT5670 codec. >> Manufacturer: LENOVO >> Product Name: 20359 >> Version: Lenovo Miix 2 10 > Interesting. Any chance that applies to the Miix 3-1030 too? no idea, you'd have to look at dmesg/DSDT and check if the same rt5640/rt5670 BIOS confusion applies. > >> + { >> + .callback = byt_thinkpad10_quirk_cb, >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), >> + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), > I guess I should run dmidecode, get the kernel sources, make a similar > change and test. Unfortunately, I will probably not have time to do that > until at least the week-end. DMI decode is only needed once you've confirmed the device can't work with the normal ACPI handling. Please provide your findings on bugzilla (dmesg, DSDT, alsa-info.sh) https://bugzilla.kernel.org/show_bug.cgi?id=96691 > > Thanks. > > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c index 18fe46e..dd250b8 100644 --- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -420,7 +420,21 @@ static const struct dmi_system_id byt_table[] = { .callback = byt_thinkpad10_quirk_cb, .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "20C3001VHH"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), }, }, { }
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec. Manufacturer: LENOVO Product Name: 20C1CTO1WW Version: ThinkPad 10 Manufacturer: LENOVO Product Name: 20C3001VHH Version: ThinkPad 10 Manufacturer: LENOVO Product Name: 20C10024GE Version: ThinkPad Tablet B Manufacturer: LENOVO Product Name: 20359 Version: Lenovo Miix 2 10 For all these devices, the same quirk is used to force the machine driver to be based on RT5670 instead of RT5640 as indicated by the BIOS. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=96691 Tested-by: Nicole Faerber <nicole.faerber@dpin.de> Tested-by: Viacheslav Ostroukh <v.dev@ostroukh.me> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/intel/atom/sst/sst_acpi.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)